[igt-dev] [PATCH i-g-t v2] tests/kms_frontbuffer_tracking: modified subtest name

Sharma, Swati2 swati2.sharma at intel.com
Thu Mar 11 07:58:03 UTC 2021


LGTM

Reviewed-by:
Swati Sharma <swati2.sharma at intel.com>

On 11-Mar-21 12:31 PM, Nidhi Gupta wrote:
> Some platforms do not have support for mappable GTT, for those platforms
> subtests with draw method as mmap-gtt will be skipped, added mmap-gtt in
> the end of the subtests name which uses it as a draw method so that filtering
> of those subtests as expected skip will be easier while assessing results.
> 
> Signed-off-by: Nidhi Gupta <nidhi1.gupta at intel.com>
> ---
>   tests/kms_frontbuffer_tracking.c | 9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
> index 14f522d8..2e74bec6 100644
> --- a/tests/kms_frontbuffer_tracking.c
> +++ b/tests/kms_frontbuffer_tracking.c
> @@ -3411,10 +3411,11 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
>   		    (t.feature & FEATURE_FBC) == 0)
>   			continue;
>   
> -		igt_subtest_f("%s-%s-%s-fliptrack",
> +		igt_subtest_f("%s-%s-%s-fliptrack-%s",
>   			      feature_str(t.feature),
>   			      pipes_str(t.pipes),
> -			      fbs_str(t.fbs))
> +			      fbs_str(t.fbs),
> +			      igt_draw_get_method_name(t.method))
>   			fliptrack_subtest(&t, FLIP_PAGEFLIP);
>   	TEST_MODE_ITER_END
>   
> @@ -3479,7 +3480,9 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
>   		    t.method != IGT_DRAW_MMAP_GTT)
>   			continue;
>   
> -		igt_subtest_f("%s-farfromfence", feature_str(t.feature))
> +		igt_subtest_f("%s-farfromfence-%s",
> +			      feature_str(t.feature),
> +			      igt_draw_get_method_name(t.method))
>   			farfromfence_subtest(&t);
>   	TEST_MODE_ITER_END
>   
> 

-- 
~Swati Sharma


More information about the igt-dev mailing list