[igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: Test 32x32 cursors

Martin Peres martin.peres at mupuf.org
Thu Mar 18 06:39:01 UTC 2021


On 18/03/2021 00:45, Lyude wrote:
> From: Lyude Paul <lyude at redhat.com>
> 
> Since pre-nve4 only has two cursor sizes (32x32 and 64x64), we should at
> least test both of them.

This adds 36 subtests, which take about 1s in average. So the runtime is 
not significantly increased on the Intel side.

It also seems that Intel should add skips or fix the kernel to support 
these 32xXX format.

@Petri, could you get someone to investigate this?

In the mean time, here is my:

Reviewed-by: Martin Peres <martin.peres at mupuf.org>

Martin
> 
> Signed-off-by: Lyude Paul <lyude at redhat.com>
> Cc: Martin Peres <martin.peres at free.fr>
> Cc: Ben Skeggs <bskeggs at redhat.com>
> Cc: Jeremy Cline <jcline at redhat.com>
> ---
>   tests/kms_cursor_crc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
> index 0be8f7f8..c70c4a8f 100644
> --- a/tests/kms_cursor_crc.c
> +++ b/tests/kms_cursor_crc.c
> @@ -683,7 +683,7 @@ static void run_tests_on_pipe(data_t *data, enum pipe pipe)
>   	igt_fixture
>   		igt_remove_fb(data->drm_fd, &data->fb);
>   
> -	for (cursor_size = 64; cursor_size <= 512; cursor_size *= 2) {
> +	for (cursor_size = 32; cursor_size <= 512; cursor_size *= 2) {
>   		int w = cursor_size;
>   		int h = cursor_size;
>   
> 


More information about the igt-dev mailing list