[igt-dev] [PATCH i-g-t] tests/core_hotunplug: Be more specific on sysfs vs. debugfs issues

Janusz Krzysztofik janusz.krzysztofik at linux.intel.com
Thu Mar 18 12:05:54 UTC 2021


Messages displayed on sysfs health check failures don't provide
information which subtree of sysfs actually failed - device sysfs
itself or device debugfs.  That information could make debugging more
easy if available.

Be more specific when reporting sysfs health check failures.

Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik at linux.intel.com>
---
 tests/core_hotunplug.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c
index e7d2a4472..56a88fefd 100644
--- a/tests/core_hotunplug.c
+++ b/tests/core_hotunplug.c
@@ -351,11 +351,13 @@ static void node_healthcheck(struct hotunplug *priv, unsigned flags)
 	if (!priv->failure) {
 		char path[200];
 
-		priv->failure = "Device sysfs healthckeck failure!";
 		local_debug("%s\n", "running device sysfs healthcheck");
-		if (igt_sysfs_path(fd_drm, path, sizeof(path)) &&
-		    igt_debugfs_path(fd_drm, path, sizeof(path)))
-			priv->failure = NULL;
+		priv->failure = "Device sysfs healthckeck failure!";
+		if (igt_sysfs_path(fd_drm, path, sizeof(path))) {
+			priv->failure = "Device debugfs healthckeck failure!";
+			if (igt_debugfs_path(fd_drm, path, sizeof(path)))
+				priv->failure = NULL;
+		}
 	}
 
 	fd_drm = close_device(fd_drm, "", "health checked ");
-- 
2.25.1



More information about the igt-dev mailing list