[igt-dev] [i-g-t] tests/i915/perf: Added check for testcase to get discarded on less than gen12 platform

[Petri Latvala]

On Thu, Mar 25, 2021 at 03:44:04PM +0530, Anand Moon wrote:
> Added check for testcase to get discarded on less than gen12 platform
> 
> Cc: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa at intel.com>
> Signed-off-by: Anand Moon <anandx.ram.moon at intel.com>
> ---
>  tests/i915/perf.c | 21 +++++++++++----------
>  1 file changed, 11 insertions(+), 10 deletions(-)
> 
> diff --git a/tests/i915/perf.c b/tests/i915/perf.c
> index 664fd0a9..18cf9fb1 100644
> --- a/tests/i915/perf.c
> +++ b/tests/i915/perf.c
> @@ -5062,19 +5062,20 @@ igt_main
>  	}
>  
>  	igt_subtest_group {
> -		igt_fixture igt_require(intel_gen(devid) >= 12);
> +		if (intel_gen(devid) >= 12) {


You can't do that. Tests must exist regardless of the running platform.


-- 
Petri Latvala



>  
> -		igt_describe("Test MI REPORT PERF COUNT for Gen 12");
> -		igt_subtest("gen12-mi-rpc")
> -			gen12_test_mi_rpc();
> +			igt_describe("Test MI REPORT PERF COUNT for Gen 12");
> +			igt_subtest("gen12-mi-rpc")
> +				gen12_test_mi_rpc();
>  
> -		igt_describe("Test OA TLB invalidate");
> -		igt_subtest("gen12-oa-tlb-invalidate")
> -			gen12_test_oa_tlb_invalidate();
> +			igt_describe("Test OA TLB invalidate");
> +			igt_subtest("gen12-oa-tlb-invalidate")
> +				gen12_test_oa_tlb_invalidate();
>  
> -		igt_describe("Measure performance for a specific context using OAR in Gen 12");
> -		igt_subtest("gen12-unprivileged-single-ctx-counters")
> -			gen12_test_single_ctx_render_target_writes_a_counter();
> +			igt_describe("Measure performance for a specific context using OAR in Gen 12");
> +			igt_subtest("gen12-unprivileged-single-ctx-counters")
> +				gen12_test_single_ctx_render_target_writes_a_counter();
> +		}
>  	}
>  
>  	igt_subtest("rc6-disable")
> -- 
> 2.31.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev