[igt-dev] [PATCH i-g-t] tests/kms_atomic_transition: Fix the is_atomic check

Juha-Pekka Heikkila juhapekka.heikkila at gmail.com
Wed Mar 31 07:32:43 UTC 2021


Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>

On 30.3.2021 19.18, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> We want to check the value of is_atomic, not its address. Should
> make the test skip correctly again when the driver doesn't advertise
> atomic support.
> 
> Cc: Nidhi Gupta <nidhi1.gupta at intel.com>
> Fixes: e796ca7ce6fe ("tests/kms_atomic_transition:reduce execution time")
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>   tests/kms_atomic_transition.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_atomic_transition.c b/tests/kms_atomic_transition.c
> index 431824d0cdb4..be60940d71bf 100644
> --- a/tests/kms_atomic_transition.c
> +++ b/tests/kms_atomic_transition.c
> @@ -993,7 +993,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>   		kmstest_set_vt_graphics_mode();
>   
>   		igt_display_require(&data.display, data.drm_fd);
> -		igt_require(&data.display.is_atomic);
> +		igt_require(data.display.is_atomic);
>   
>   		igt_display_require_output(&data.display);
>   
> 



More information about the igt-dev mailing list