[igt-dev] [PATCH i-g-t 1/3] tests/kms_ccs: Skip CCS color clear value check for randomizing subtests

[Rodrigo Siqueira]

On 05/05, Imre Deak wrote:
> Hi,
> 
> On Tue, May 04, 2021 at 08:23:05PM -0400, Rodrigo Siqueira wrote:
> > Hi,
> > 
> > I looked at kms_ccs and tried to find a reference for "color control
> > surfaces" in DRM, and I found multiple references for this format in
> > i915.
> 
> CCS means here Compression Control Surface. Yes, the render and media
> GPU engines use their own compression format, hence multiple CCS
> modifiers are needed. There are also format differences between
> platforms, which further increases the number of modifiers.
> 
> > Is it an Intel-specific format? Is kms_ccs a test that can be
> > executed in different ASICs?
> 
> Yes, the CCS FB modifiers are Intel specific and kms_ccs will not run on
> other platforms.

Thanks for the explanation.
 
> --Imre
> 
> > Thanks
> > Siqueira
> > 
> > On 04/29, Imre Deak wrote:
> > > When filling the color planes with randomized content, the color clear
> > > values won't match what the HW actually wrote there, so skip the clear
> > > value check in this case.
> > > 
> > > Cc: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
> > > Cc: Mika Kahola <mika.kahola at intel.com>
> > > Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > > Signed-off-by: Imre Deak <imre.deak at intel.com>
> > > ---
> > >  tests/kms_ccs.c | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
> > > index 30e0fdb54..61c9b2277 100644
> > > --- a/tests/kms_ccs.c
> > > +++ b/tests/kms_ccs.c
> > > @@ -195,7 +195,7 @@ static void check_ccs_cc_plane(int drm_fd, igt_fb_t *fb, int plane, const float
> > >  	munmap(map, fb->size);
> > >  };
> > >  
> > > -static void check_all_ccs_planes(int drm_fd, igt_fb_t *fb, const float *cc_color)
> > > +static void check_all_ccs_planes(int drm_fd, igt_fb_t *fb, const float *cc_color, bool check_cc_plane)
> > >  {
> > >  	int i;
> > >  
> > > @@ -203,7 +203,7 @@ static void check_all_ccs_planes(int drm_fd, igt_fb_t *fb, const float *cc_color
> > >  		if (igt_fb_is_ccs_plane(fb, i) &&
> > >  		    !igt_fb_is_gen12_ccs_cc_plane(fb, i))
> > >  			check_ccs_plane(drm_fd, fb, i);
> > > -		else if (igt_fb_is_gen12_ccs_cc_plane(fb, i))
> > > +		else if (igt_fb_is_gen12_ccs_cc_plane(fb, i) && check_cc_plane)
> > >  			check_ccs_cc_plane(drm_fd, fb, i, cc_color);
> > >  	}
> > >  }
> > > @@ -348,7 +348,7 @@ static void generate_fb(data_t *data, struct igt_fb *fb,
> > >  		igt_assert_eq(ret, 0);
> > >  
> > >  	if (check_ccs_planes)
> > > -		check_all_ccs_planes(data->drm_fd, fb, cc_color);
> > > +		check_all_ccs_planes(data->drm_fd, fb, cc_color, !(data->flags & TEST_RANDOM));
> > >  
> > >  	fb->fb_id = f.fb_id;
> > >  }
> > > -- 
> > > 2.27.0
> > > 
> > > _______________________________________________
> > > igt-dev mailing list
> > > igt-dev at lists.freedesktop.org
> > > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Figt-dev&data=04%7C01%7CRodrigo.Siqueira%40amd.com%7Cedb4aea1c4e249252dfb08d90fb06aef%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637558072643709539%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=%2FwF620WrokFKD77Athnep%2FYb%2BY6AFOl%2FPj%2B%2F1PdCfL0%3D&reserved=0
> > 
> > -- 
> > Rodrigo Siqueira
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsiqueira.tech%2F&data=04%7C01%7CRodrigo.Siqueira%40amd.com%7Cedb4aea1c4e249252dfb08d90fb06aef%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637558072643719534%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=oKsprNNETtsy012m2FFAtNiX71NfsTxjapl1FW2dEcw%3D&reserved=0
> 
> 

-- 
Rodrigo Siqueira
https://siqueira.tech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/igt-dev/attachments/20210505/e45f35a4/attachment.sig>