[igt-dev] [PATCH i-g-t 1/2] tests/kms_psr2_sf: Add subtest description

Karthik B S karthik.b.s at intel.com
Thu May 6 04:37:09 UTC 2021


On 5/4/2021 11:10 AM, Pankaj Bharadiya wrote:
> Add description for all subtests.
>
> Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya at intel.com>

Looks good to me.

Reviewed-by: Karthik B S <karthik.b.s at intel.com>

> ---
>   tests/kms_psr2_sf.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/tests/kms_psr2_sf.c b/tests/kms_psr2_sf.c
> index 8d3e13019..fd91b4865 100644
> --- a/tests/kms_psr2_sf.c
> +++ b/tests/kms_psr2_sf.c
> @@ -589,6 +589,7 @@ igt_main
>   
>   	/* Verify primary plane selective fetch */
>   	for (i = 1; i <= MAX_DAMAGE_AREAS; i++) {
> +		igt_describe("Test that selective fetch works on primary plane");
>   		igt_subtest_f("primary-%s-sf-dmg-area-%d", op_str(data.op), i) {
>   			data.damage_area_count = i;
>   			data.test_plane_id = DRM_PLANE_TYPE_PRIMARY;
> @@ -600,6 +601,7 @@ igt_main
>   
>   	/* Verify overlay plane selective fetch */
>   	for (i = 1; i <= MAX_DAMAGE_AREAS; i++) {
> +		igt_describe("Test that selective fetch works on overlay plane");
>   		igt_subtest_f("overlay-%s-sf-dmg-area-%d", op_str(data.op), i) {
>   			data.damage_area_count = i;
>   			data.test_plane_id = DRM_PLANE_TYPE_OVERLAY;
> @@ -610,6 +612,7 @@ igt_main
>   	}
>   
>   	/* Verify overlay plane selective fetch */
> +	igt_describe("Test that selective fetch works on cursor plane");
>   	igt_subtest_f("cursor-%s-sf", op_str(data.op)) {
>   		data.damage_area_count = 1;
>   		data.test_plane_id = DRM_PLANE_TYPE_CURSOR;
> @@ -622,6 +625,7 @@ igt_main
>   	data.op = PLANE_MOVE;
>   	/* Verify overlay plane move selective fetch */
>   	for (i = POS_TOP_LEFT; i <= POS_BOTTOM_RIGHT ; i++) {
> +		igt_describe("Test that selective fetch works on moving overlay plane");
>   		igt_subtest_f("%s-sf-dmg-area-%d", op_str(data.op), i) {
>   			data.pos = i;
>   			data.test_plane_id = DRM_PLANE_TYPE_OVERLAY;
> @@ -634,6 +638,8 @@ igt_main
>   	/* Verify primary plane selective fetch with overplay plane blended */
>   	data.op = OVERLAY_PRIM_UPDATE;
>   	for (i = 1; i <= MAX_DAMAGE_AREAS; i++) {
> +		igt_describe("Test that selective fetch works on primary plane "
> +			     "with blended overlay plane");
>   		igt_subtest_f("%s-sf-dmg-area-%d", op_str(data.op), i) {
>   			data.damage_area_count = i;
>   			data.test_plane_id = DRM_PLANE_TYPE_PRIMARY;




More information about the igt-dev mailing list