[igt-dev] [PATCH i-g-t] lib/igt_chamelium: Retry DP FSM on Failure

[Joshi, Kunal1]

>>From: Latvala, Petri <petri.latvala at intel.com> 
>>Sent: Wednesday, May 5, 2021 1:50 PM
>>To: Joshi, Kunal1 <kunal1.joshi at intel.com>
>>Cc: igt-dev at lists.freedesktop.org; Modem, Bhanuprakash <bhanuprakash.modem at intel.com>
>>Subject: Re: [PATCH i-g-t] lib/igt_chamelium: Retry DP FSM on Failure

>>On Tue, May 04, 2021 at 07:04:15AM +0000, Kunal Joshi wrote:
>> We have a thread called chamelium_fsm_mon which monitors HPD events 
>>triggered by chamelium, Unfortunately not always the HPD event arrives 
>> in a fixed interval (mostly does), Quick fix to this is to retry.
>> 
>> v2: Remove redundant assert (Bhanu)
>> 
>> Fixes :- https://gitlab.freedesktop.org/drm/intel/-/issues/262
>> Cc: Petri Latvala <petri.latvala at intel.com>
>> Cc: Modem Bhanuprakash <bhanuprakash.modem at intel.com>
>> Signed-off-by: Kunal Joshi <kunal1.joshi at intel.com>

>Another extra empty line.
>With the extra empty lines removed this is
>Reviewed-by: Petri Latvala <petri.latvala at intel.com>


>Is CaptureVideo really the only method that needs this retrying?
CaptureVideo is the only command currently which can trigger DP FSM,
There are other commands such as StartVideoCapture but we don't use them,
But will add those incase somebody uses it.

Thanks for the review and feedback petri.