[igt-dev] [PATCH i-g-t] tests/kms_lease: Add subtest description

Hagaragi, Arundhati arundhati.hagaragi at intel.com
Fri May 7 16:53:03 UTC 2021



-----Original Message-----
From: Latvala, Petri <petri.latvala at intel.com> 
Sent: Friday, May 7, 2021 7:34 PM
To: Hagaragi, Arundhati <arundhati.hagaragi at intel.com>
Cc: igt-dev at lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_lease: Add subtest description

On Fri, May 07, 2021 at 06:20:39PM +0530, Arundhati Hagaragi wrote:
> Added description for subtest
> 
> Signed-off-by: Arundhati Hagaragi <arundhati.hagaragi at intel.com>
> ---
>  tests/kms_lease.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/kms_lease.c b/tests/kms_lease.c index 
> 6397ef8f..957af1e0 100644
> --- a/tests/kms_lease.c
> +++ b/tests/kms_lease.c
> @@ -1307,6 +1307,7 @@ igt_main
>  
>  	for (f = funcs; f->name; f++) {
>  
> +		igt_describe("Tests the valid crtc/connector combinations for given 
> +function");


That doesn't help at all. You need to document what each of those functions do, separately.

Add a description to each of the elements in the funcs array so you can do

for (f = funcs; f->name; f++) {
  igt_describe("%s", f->desc);
  igt_subtest_f("%s", f->name) {
     run_test(&data, f->func);
  }
}


--
Petri Latvala

Thanks Petri, Will look into it.

Thanks,
Arundhati


More information about the igt-dev mailing list