[igt-dev] [PATCH i-g-t 03/16] Add basic PXP testing of buffer and context alloc

[Dixit, Ashutosh]

On Sat, 15 May 2021 16:58:24 -0700, Teres Alexis, Alan Previn wrote:
>
> I have been using checkpatch.pl on last few revs with zero issues. One caveat though and I just realize this now:
> - when I run checkpatch "--no-tree -f my_modified_file.c", I don't get any warnings.
> - when I run but running on the patches I get warnings about "exceeding 100 columns".
>
> What is the official hard rule? Are we at 120, 100 or 80?

IGT follows the kernel coding style. The kernel originally had a 80 char
width limit which was recently increased to 100 that is why checkpatch now
complains about 100.

So yes it's either 80 or 100 however you want to do it. But the official
hard limit is now 100 I'd think. So I'd fix it to be within one of those
widths.

>
> ...alan
>
> -----Original Message-----
> From: Dixit, Ashutosh <ashutosh.dixit at intel.com>
> Sent: Saturday, May 15, 2021 4:16 PM
> To: Teres Alexis, Alan Previn <alan.previn.teres.alexis at intel.com>
> Cc: igt-dev at lists.freedesktop.org
> Subject: Re: [igt-dev] [PATCH i-g-t 03/16] Add basic PXP testing of buffer and context alloc
>
> On Fri, 14 May 2021 02:40:26 -0700, Teres Alexis, Alan Previn wrote:
> >
> >
> > Okay - i will fix them all and push a new rev.
>
> Mostly coding style looks good now but an easy way to check for style/indendation issues in the code is to run checkpatch from the kernel on the IGT patches and fix all issues which are not kernel specific (and also ignore those which don't make sense):
>
> https://github.com/torvalds/linux/blob/master/scripts/checkpatch.pl
>
>
>