[igt-dev] [PATCH i-g-t v4] tests/kms_lease: Add subtest description

[Karthik B S]

On 5/18/2021 2:28 PM, Arundhati Hagaragi wrote:
> Added description for subtest
>
> Signed-off-by: Arundhati Hagaragi <arundhati.hagaragi at intel.com>
> Cc: B S Karthik <karthik.b.s at intel.com>
> Cc: Gupta Nidhi1 <nidhi1.gupta at intel.com>
>
> v2: Modified & applied description to each tests seperately. (Petri)
> v3, v4: Modified description of subtests (Karthik)
> ---
>   tests/kms_lease.c | 35 +++++++++++++++++++++--------------
>   1 file changed, 21 insertions(+), 14 deletions(-)
>
> diff --git a/tests/kms_lease.c b/tests/kms_lease.c
> index 6397ef8f..0b7a560f 100644
> --- a/tests/kms_lease.c
> +++ b/tests/kms_lease.c
> @@ -1281,21 +1281,27 @@ igt_main
>   	const struct {
>   		const char *name;
>   		void (*func)(data_t *);
> +		const char *desc;
>   	} funcs[] = {
> -		{ "simple_lease", simple_lease },
> -		{ "lessee_list", lessee_list },
> -		{ "lease_get", lease_get },
> -		{ "lease_unleased_connector", lease_unleased_connector },
> -		{ "lease_unleased_crtc", lease_unleased_crtc },
> -		{ "lease_revoke", lease_revoke },
> -		{ "lease_again", lease_again },
> -		{ "lease_invalid_connector", lease_invalid_connector },
> -		{ "lease_invalid_crtc", lease_invalid_crtc },
> -		{ "lease_invalid_plane", lease_invalid_plane },
> -		{ "page_flip_implicit_plane", page_flip_implicit_plane },
> -		{ "setcrtc_implicit_plane", setcrtc_implicit_plane },
> -		{ "cursor_implicit_plane", cursor_implicit_plane },
> -		{ "atomic_implicit_crtc", atomic_implicit_crtc },
> +		{ "simple_lease", simple_lease, "Check if create lease ioctl call works" },
> +		{ "lessee_list", lessee_list, "Check if listed lease is same as created one" },
> +		{ "lease_get", lease_get, "Tests getting the required contents of a lease" },
> +		{ "lease_unleased_connector", lease_unleased_connector, "Negative test by trying to"
> +			" use an unleased connector " },
> +		{ "lease_unleased_crtc", lease_unleased_crtc, "Negative test by trying to use an unleased crtc" },
> +		{ "lease_revoke", lease_revoke, "Tests revocation of lease" },
> +		{ "lease_again", lease_again, "Tests leasing objects more than once" },
> +		{ "lease_invalid_connector", lease_invalid_connector, "Tests leasing an invalid connector" },
> +		{ "lease_invalid_crtc", lease_invalid_crtc, "Tests leasing an invalid crtc" },
> +		{ "lease_invalid_plane", lease_invalid_plane, "Tests leasing an invalid plane" },
> +		{ "page_flip_implicit_plane", page_flip_implicit_plane, "Negative test by using a "
> +			"non-primary plane with the page flip ioctl" },
> +		{ "setcrtc_implicit_plane", setcrtc_implicit_plane, "Negative test by using a "
> +			"non-primary plane with the setcrtc ioctl" },
> +		{ "cursor_implicit_plane", cursor_implicit_plane, "Negative test by using a non-primary"
> +			" plane with setcursor ioctl" },
> +		{ "atomic_implicit_crtc", atomic_implicit_crtc, "Negative test by using a crtc-id "
> +			"property with atomic ioctl" },

Please change this to "Negative test by using a different crtc with 
atomic ioctl".

With this fixed, the patch looks good to me.

Reviewed-by: Karthik B S <karthik.b.s at intel.com>

>   		{ }
>   	}, *f;
>   
> @@ -1307,6 +1313,7 @@ igt_main
>   
>   	for (f = funcs; f->name; f++) {
>   
> +		igt_describe(f->desc);
>   		igt_subtest_f("%s", f->name) {
>   			run_test(&data, f->func);
>   		}