[igt-dev] [v6 i-g-t 13/14] tests/kms_flip_scaled_crc: Reset the state before exiting the test
Nautiyal, Ankit K
ankit.k.nautiyal at intel.com
Wed May 19 06:42:05 UTC 2021
On 5/12/2021 10:35 PM, Bhanuprakash Modem wrote:
> Before starting the next subtest, clean up the states to default
> values, those are assumed by other tests.
>
> Cc: Imre Deak <imre.deak at intel.com>
> Cc: Ankit Nautiyal <ankit.k.nautiyal at intel.com>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
> ---
> tests/kms_flip_scaled_crc.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/tests/kms_flip_scaled_crc.c b/tests/kms_flip_scaled_crc.c
> index 4923f1235..671ba7367 100644
> --- a/tests/kms_flip_scaled_crc.c
> +++ b/tests/kms_flip_scaled_crc.c
> @@ -156,6 +156,7 @@ static void test_flip_to_scaled(data_t *data, uint32_t index, enum pipe pipe,
> int ret;
>
> igt_display_reset(&data->display);
> + igt_display_commit2(&data->display, COMMIT_ATOMIC);
>
> igt_debug("running on output %s pipe %s\n", output->name,
> kmstest_pipe_name(pipe));
> @@ -246,6 +247,10 @@ static void test_flip_to_scaled(data_t *data, uint32_t index, enum pipe pipe,
> data->pipe_crc = NULL;
>
> clear_lut(data, pipe);
> +
> + igt_output_set_pipe(output, pipe);
Shouldn't it be PIPE_NONE instead of pipe in the args?
Otherwise:
LGTM.
Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal at intel.com>
> + igt_plane_set_fb(primary, NULL);
> + igt_display_commit2(&data->display, COMMIT_ATOMIC);
> }
>
> igt_main
More information about the igt-dev
mailing list