[igt-dev] [v6 i-g-t 11/14] tests/kms_plane_lowres: Reset the state before exiting the test

Nautiyal, Ankit K ankit.k.nautiyal at intel.com
Wed May 19 07:01:38 UTC 2021


LGTM.

Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal at intel.com>

On 5/12/2021 10:35 PM, Bhanuprakash Modem wrote:
> Before starting the next subtest, clean up the states to default
> values, those are assumed by other tests. This patch will also fix
> few redundant checks.
>
> Cc: Imre Deak <imre.deak at intel.com>
> Cc: Ankit Nautiyal <ankit.k.nautiyal at intel.com>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
> ---
>   tests/kms_plane_lowres.c | 9 +++------
>   1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/tests/kms_plane_lowres.c b/tests/kms_plane_lowres.c
> index 5cfe53c8b..95346e289 100644
> --- a/tests/kms_plane_lowres.c
> +++ b/tests/kms_plane_lowres.c
> @@ -270,16 +270,13 @@ test_planes_on_pipe(data_t *data, uint64_t modifier)
>   	igt_info("Testing connector %s using pipe %s\n",
>   		 igt_output_name(data->output), kmstest_pipe_name(data->pipe));
>   
> -	for_each_plane_on_pipe(&data->display, data->pipe, plane) {
> -		data->output = igt_get_single_output_for_pipe(&data->display, data->pipe);
> -		igt_require(data->output);
> -
> +	for_each_plane_on_pipe(&data->display, data->pipe, plane)
>   		tested += test_planes_on_pipe_with_output(data, plane, modifier);
> -	}
>   
> -	igt_assert(tested > 0);
>   	igt_output_set_pipe(data->output, PIPE_NONE);
>   	igt_display_commit2(&data->display, COMMIT_ATOMIC);
> +
> +	igt_assert(tested > 0);
>   }
>   
>   igt_main


More information about the igt-dev mailing list