[igt-dev] [PATCH i-g-t 1/2] lib/meson: Fix build

Petri Latvala petri.latvala at intel.com
Mon Nov 1 09:20:36 UTC 2021


On Fri, Oct 29, 2021 at 05:07:43PM -0700, José Roberto de Souza wrote:
> Getting:
> ../lib/meson.build:158:4: ERROR: Function does not take positional arguments.
> with meson 0.60.
> 
> Acording to documentation underscorify() do not take any arguments as
> it will be executed over the string/object instace of the class.
> https://mesonbuild.com/Reference-manual_elementary_str.html#strunderscorify
> 
> Not sure why older versions was not complaning about it.
> 
> Signed-off-by: José Roberto de Souza <jose.souza at intel.com>

https://patchwork.freedesktop.org/patch/461649/?series=96375&rev=1

Wanna throw a something-by: line to that patch?

> ---
>  lib/meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/meson.build b/lib/meson.build
> index c3080fc82..297b0ad26 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -155,7 +155,7 @@ lib_version = vcs_tag(input : 'version.h.in', output : 'version.h',
>  
>  lib_intermediates = []
>  foreach f: lib_sources
> -    name = f.underscorify(f)
> +    name = f.underscorify()
>      lib = static_library('igt-' + name,
>  	[ f, lib_version ],
>  	include_directories: inc,
> -- 
> 2.33.1
> 


More information about the igt-dev mailing list