[igt-dev] [PATCH i-g-t 0/4] lib/igt_fb/tgl+: Remove CCS FB layout restrictions

Juha-Pekka Heikkila juhapekka.heikkila at gmail.com
Tue Nov 2 13:29:54 UTC 2021


I didn't spot anything to specially comment about, set look ok to me 
including v2 of patch #2.

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>

On 27.10.2021 0.26, Imre Deak wrote:
> Some restrictions on the stride, offset and size of TGL+ CCS FB surfaces
> are not something the HW requires, so this patchset removes those.
> 
> On ADLP this also removes the main and CCS AUX stride restriction
> required by the CCS modifier uAPI, making the uAPI of ADLP identical to
> that of TGL.
> 
> Because of the uAPI change above the CI results for this patchset are
> only valid with the corresponding kernel changes which I'll submit later
> adding a reference to this one, so the two are tested together.
> 
> I tested these changes with the kernel upcoming kernel patchset on
> SKL/TGL/ADLP.
> 
> Imre Deak (4):
>    lib/igt_fb/adlp: Remove CCS FB stride alignment restrictions
>    lib/igt_fb/tgl+: Prevent CCS FB UV surface offset overalignment
>    lib/igt_fb/tgl+: Remove CCS FB 4 tile height alignment restriction
>    lib/igt_fb/tgl+: Prevent CCS FB AUX surface size overalignment
> 
>   lib/igt_fb.c            | 87 +++++++++++++++++++++++++++--------------
>   lib/intel_aux_pgtable.c | 66 ++++---------------------------
>   lib/intel_bufops.c      |  2 +-
>   3 files changed, 66 insertions(+), 89 deletions(-)
> 



More information about the igt-dev mailing list