[igt-dev] [PATCH i-g-t] Revert "test/kms_atomic: Skip plane overlay test for amdgpu"

Rodrigo Siqueira Rodrigo.Siqueira at amd.com
Thu Nov 4 14:22:12 UTC 2021


This reverts commit 080869f804cb86b25a38889e5ce9a870571cd8c4.

Thanks to Simon's patch to amd-staging-drm-next, we recently re-enabled
overlay support in our driver. We don't need to skip overlay tests in
the kms_atomic anymore; for this reason, this commit reverted the skip
when we have overlay tests.

Cc: Simon Ser <contact at emersion.fr>
Cc: Harry Wentland <harry.wentland at amd.com>
Cc: Nicholas Choi <Nicholas.Choi at amd.com>
Cc: Hayden Goodfellow <Hayden.Goodfellow at amd.com>
Cc: Mark Yacoub <markyacoub at chromium.org>

Signed-off-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
---
 tests/kms_atomic.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
index 1657624e..5295c8f5 100644
--- a/tests/kms_atomic.c
+++ b/tests/kms_atomic.c
@@ -502,13 +502,6 @@ static void plane_overlay(igt_pipe_t *pipe, igt_output_t *output, igt_plane_t *p
 	uint32_t w = mode->hdisplay / 2;
 	uint32_t h = mode->vdisplay / 2;
 
-	/* On AMD, with hardware cursor, overlay plane must fully cover
-	 * the primary plane (underlay). AMD does not support this test
-	 * scenario
-	 */
-	igt_require_f(!is_amdgpu_device(output->display->drm_fd),
-		      "Overlay must fully cover the primary plane on AMD\n");
-
 	igt_require(format != 0);
 
 	igt_create_pattern_fb(pipe->display->drm_fd, w, h,
-- 
2.25.1



More information about the igt-dev mailing list