[igt-dev] [PATCH i-g-t] runner: Correctly handle abort before first test

Petri Latvala petri.latvala at intel.com
Mon Nov 8 11:55:24 UTC 2021


Don't leave the execution in a "please resume me" state if bootup
causes an abort condition. Especially handle the case of abort on
bootup when resuming correctly, so that it doesn't attempt to run a
test on a tainted kernel if we've explicitly configured the runner to
not execute when there's a taint.

Signed-off-by: Petri Latvala <petri.latvala at intel.com>
Cc: Arkadiusz Hiler <arek at hiler.eu>
Cc: Chris Wilson <chris at chris-wilson.co.uk>
---
 runner/executor.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/runner/executor.c b/runner/executor.c
index 9b582179..5007ed75 100644
--- a/runner/executor.c
+++ b/runner/executor.c
@@ -1766,7 +1766,7 @@ bool execute(struct execute_state *state,
 	close(unamefd);
 
 	/* Check if we're already in abort-state at bootup */
-	if (!state->resuming) {
+	{
 		char *reason;
 
 		if ((reason = need_to_abort(settings)) != NULL) {
@@ -1775,7 +1775,13 @@ bool execute(struct execute_state *state,
 			free(reason);
 			free(nexttest);
 
-			status = false;
+			/*
+			 * If bootup causes an abort condition, assume
+			 * that it would happen on every boot.  Thus,
+			 * the correct state of this execution is "all
+			 * finished".
+			 */
+			status = true;
 
 			goto end;
 		}
-- 
2.29.2



More information about the igt-dev mailing list