[igt-dev] [PATCH i-g-t] tests/device_reset: remove artificial timeout

Zbigniew Kempczyński zbigniew.kempczynski at intel.com
Wed Nov 10 10:35:36 UTC 2021


On Mon, Nov 08, 2021 at 01:47:46PM +0000, Marcin Bernatowicz wrote:
> Do not use artificial timeout. Let the test fail or finish.
> 
> Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz at linux.intel.com>
> ---
>  tests/device_reset.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/tests/device_reset.c b/tests/device_reset.c
> index 982ba5ef2a..e60d4c7fde 100644
> --- a/tests/device_reset.c
> +++ b/tests/device_reset.c
> @@ -301,8 +301,6 @@ igt_main
>  		set_device_filter(dev_path);
>  
>  		igt_skip_on(!is_sysfs_reset_supported(dev.fds.dev));
> -
> -		igt_set_timeout(60, "device reset tests timed out after 60s");
>  	}
>  
>  	igt_describe("Unbinds driver from device, initiates reset"
> @@ -319,7 +317,6 @@ igt_main
>  	}
>  
>  	igt_fixture {
> -		igt_reset_timeout();
>  		cleanup_device_fds(&dev);
>  	}
>  }
> -- 
> 2.30.2
> 

Ok, we've discussed about this - if other vendors will complain 
in the future we will revert and skip setting this timeout on i915.
So:

Acked-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>

--
Zbigniew


More information about the igt-dev mailing list