[igt-dev] [PATCH i-g-t 1/2] tests/i915/gem_lmem_swapping: Add the gem_lmem_swapping test
Matthew Auld
matthew.william.auld at gmail.com
Tue Nov 16 10:31:38 UTC 2021
On Mon, 15 Nov 2021 at 07:16, Zbigniew Kempczyński
<zbigniew.kempczynski at intel.com> wrote:
>
> From: CQ Tang <cq.tang at intel.com>
>
> This test exercises the lmem eviction functionality with one
> dynamic subtest per lmem region.
>
> In essence the various subtests create lmem buffers objects consuming more
> lmem memory than available and check that they are successful submitting
> workload subsets whose lmem size requirements are smaller than the total
> amount of lmem available, forcing eviction of buffer objects under
> various conditions.
>
> v2: - addressing review comments (handling seed, minor cleanups) (Zbigniew)
> - add dynamic_lmem_subtest() macro (Maarten)
>
> v3: - make seed unique for each process (Zbigniew)
> - add simple igt_describe() (Petri)
>
> Signed-off-by: CQ Tang <cq.tang at intel.com>
> Co-developed-by: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at linux.intel.com>
> Co-developed-by: Ashutosh Dixit <ashutosh.dixit at intel.com>
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit at intel.com>
> Co-developed-by: Ayaz A Siddiqui <ayaz.siddiqui at intel.com>
> Signed-off-by: Ayaz A Siddiqui <ayaz.siddiqui at intel.com>
> Co-developed-by: Thomas Hellström <thomas.hellstrom at linux.intel.com>
> Signed-off-by: Thomas Hellström <thomas.hellstrom at linux.intel.com>
> Co-developed-by: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Co-developed-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> Acked-by: Petri Latvala <petri.latvala at intel.com>
> ---
> tests/i915/gem_lmem_swapping.c | 550 +++++++++++++++++++++++++++++++++
> tests/meson.build | 1 +
> 2 files changed, 551 insertions(+)
> create mode 100644 tests/i915/gem_lmem_swapping.c
>
> diff --git a/tests/i915/gem_lmem_swapping.c b/tests/i915/gem_lmem_swapping.c
> new file mode 100644
> index 000000000..786110338
> --- /dev/null
> +++ b/tests/i915/gem_lmem_swapping.c
> @@ -0,0 +1,550 @@
> +// SPDX-License-Identifier: MIT
> +/*
> + * Copyright © 2021 Intel Corporation
> + */
> +
> +#include "i915/gem.h"
> +#include "i915/gem_create.h"
> +#include "i915/gem_vm.h"
> +#include "i915/intel_memory_region.h"
> +#include "igt.h"
> +#include "igt_kmod.h"
> +#include <unistd.h>
> +#include <stdlib.h>
> +#include <stdint.h>
> +#include <stdio.h>
> +#include <string.h>
> +#include <fcntl.h>
> +#include <inttypes.h>
> +#include <errno.h>
> +#include <sys/stat.h>
> +#include <sys/ioctl.h>
> +#include <sys/time.h>
> +#include <sys/wait.h>
> +#include "drm.h"
> +
> +IGT_TEST_DESCRIPTION("Exercise local memory swapping.");
> +
> +#define __round_mask(x, y) ((__typeof__(x))((y) - 1))
> +#define round_up(x, y) ((((x) - 1) | __round_mask(x, y)) + 1)
> +
> +#define PAGE_SIZE (1ULL << 12)
> +#define SZ_64K (16 * PAGE_SIZE)
> +
> +static const char *readable_unit(uint64_t size)
> +{
> + return size >> 20 ? "MiB" : size >> 10 ? "KiB" : "Bytes";
> +}
> +
> +static uint64_t readable_size(uint64_t size)
> +{
> + return size >> 20 ? size >> 20 : size >> 10 ? size >> 10 : size;
> +}
> +
> +struct {
> + unsigned int seed;
> + bool user_seed;
> +} opt;
> +
> +struct params {
> + struct {
> + uint64_t min;
> + uint64_t max;
> + } size;
> + unsigned int count;
> + unsigned int loops;
> + unsigned int mem_limit;
> +#define TEST_VERIFY (1 << 0)
> +#define TEST_PARALLEL (1 << 1)
> +#define TEST_HEAVY (1 << 2)
> +#define TEST_RANDOM (1 << 3)
> +#define TEST_ENGINES (1 << 4)
> +#define TEST_MULTI (1 << 5)
> + unsigned int flags;
> + unsigned int seed;
> + bool oom_test;
> +};
> +
> +struct object {
> + uint64_t size;
> + uint32_t seed;
> + uint32_t handle;
> +};
> +
> +static uint32_t create_bo(int i915,
> + uint64_t size,
> + struct drm_i915_gem_memory_class_instance *region,
> + bool do_oom_test)
> +{
> + uint32_t handle;
> + int ret;
> +
> +retry:
> + ret = __gem_create_in_memory_region_list(i915, &handle, &size, region, 1);
> + if (do_oom_test && (ret == -ENOMEM || ret == -ENXIO))
AFAIK __gem_create doesn't allocate any pages(at least on drm-tip),
just a "shell" object, so we shouldn't expect to see something like
-ENXIO here. Hopefully this doesn't change the meaning of some test
below using this?
> + goto retry;
> + igt_assert_eq(ret, 0);
> + return handle;
> +}
> +
> +static unsigned int __num_engines__;
> +
> +static void
> +init_object(int i915, struct object *obj, unsigned long seed, unsigned int flags)
> +{
> + unsigned int j;
> + uint32_t *buf;
> +
> + obj->seed = seed;
> +
> + buf = gem_mmap_offset__fixed(i915, obj->handle, 0, obj->size, PROT_WRITE);
> +
> + for (j = 0; j < obj->size / sizeof(*buf); j++)
> + buf[j] = seed++;
> +
> + munmap(buf, obj->size);
> +}
> +
> +static void
> +verify_object(int i915, const struct object *obj, unsigned int flags)
> +{
> + unsigned long j;
> + uint32_t *buf;
> +
> + buf = gem_mmap_offset__fixed(i915, obj->handle, 0, obj->size, PROT_READ);
> +
> + for (j = 0; j < obj->size / PAGE_SIZE; j++) {
> + unsigned long x = (j * PAGE_SIZE + rand() % PAGE_SIZE) / sizeof(*buf);
> + uint32_t val = obj->seed + x;
> +
> + igt_assert_f(buf[x] == val,
> + "Object mismatch at offset %zu - found %08x, expected %08x; difference:%08x!\n",
> + x * sizeof(*buf), buf[x], val, buf[x] ^ val);
> + }
> +
> + munmap(buf, obj->size);
> +}
> +
> +static void move_to_lmem(int i915,
> + struct object *list,
> + unsigned int num,
> + uint32_t batch,
> + unsigned int engine,
> + bool do_oom_test)
> +{
> + struct drm_i915_gem_exec_object2 obj[1 + num];
> + struct drm_i915_gem_execbuffer2 eb = {
> + .buffers_ptr = to_user_pointer(obj),
> + .buffer_count = 1 + num,
> + .flags = I915_EXEC_NO_RELOC | I915_EXEC_HANDLE_LUT | engine,
> + };
> + unsigned int i, ret;
> +
> + memset(obj, 0, sizeof(obj));
> +
> + for (i = 0; i < num; i++) {
> + obj[i].handle = list[i].handle;
> + obj[i].flags = EXEC_OBJECT_SUPPORTS_48B_ADDRESS;
> + }
> +
> + obj[i].handle = batch;
> +retry:
> + ret = __gem_execbuf(i915, &eb);
> + if (do_oom_test && (ret == -ENOMEM || ret == -ENXIO))
> + goto retry;
> + igt_assert_eq(ret, 0);
> +}
> +
> +static void __do_evict(int i915,
> + struct drm_i915_gem_memory_class_instance *region,
> + struct params *params,
> + unsigned int seed)
> +{
> + const unsigned int max_swap_in = params->count / 100 + 1;
> + const uint32_t bbe = MI_BATCH_BUFFER_END;
> + struct object *objects, *obj, *list;
> + uint32_t batch;
> + unsigned int engine = 0;
> + unsigned int i, l;
> + uint64_t size;
> + struct timespec t = {};
> + unsigned int num;
> +
> + __gem_context_set_persistence(i915, 0, false);
> + size = 4096;
> + batch = create_bo(i915, size, region, params->oom_test);
> +
> + gem_write(i915, batch, 0, &bbe, sizeof(bbe));
> +
> + objects = calloc(params->count, sizeof(*objects));
> + igt_assert(objects);
> +
> + list = calloc(max_swap_in, sizeof(*list));
> + igt_assert(list);
> +
> + srand(seed);
> +
> + /* Create the initial working set of objects. */
> +
> + size = 0;
> + for (i = 0, obj = objects; i < params->count; i++, obj++) {
> + if (params->flags & TEST_RANDOM)
> + obj->size = rand() %
> + (params->size.max - params->size.min) +
> + params->size.min;
> + else
> + obj->size = params->size.min;
> +
> + size += obj->size;
> + if ((size >> 20) > params->mem_limit) {
> + params->count = i;
> + break;
> + }
> + obj->handle = create_bo(i915, obj->size, region, params->oom_test);
> +
> + if (params->flags & TEST_VERIFY)
> + init_object(i915, obj, rand(), params->flags);
> + else
> + move_to_lmem(i915, objects + i, 1, batch, engine,
> + params->oom_test);
> + }
> +
> + igt_debug("obj size min/max=%lu %s/%lu %s, count=%u, seed: %u\n",
> + readable_size(params->size.min), readable_unit(params->size.min),
> + readable_size(params->size.max), readable_unit(params->size.max),
> + params->count, seed);
> +
> + /*
> + * Move random objects back into lmem.
> + * for TEST_MULTI runs, make each object count s a loop to
> + * avoid excessive run times
Strange formatting?
> + */
> + for (l = 0; l < params->loops && igt_seconds_elapsed(&t) < 300; l += num) {
> + unsigned int idx = rand() % params->count;
> +
> + num = params->flags & TEST_MULTI ? rand() % max_swap_in + 1 : 1;
> + for (i = 0; i < num; i++) {
> + list[i] = objects[idx];
> + idx = (idx + 1) % params->count;
> + }
> +
> + move_to_lmem(i915, list, num, batch, engine, params->oom_test);
> +
> + if (params->flags & TEST_ENGINES)
> + engine = (engine + 1) % __num_engines__;
> +
> + if (params->flags & TEST_VERIFY) {
> + for (i = 0; i < num; i++)
> + verify_object(i915, &list[i], params->flags);
> +
> + /* Update random object - may swap it back in. */
> + i = rand() % params->count;
> + init_object(i915, &objects[i], rand(), params->flags);
> + }
> + }
> +
> + for (i = 0; i < params->count; i++)
> + gem_close(i915, objects[i].handle);
> +
> + free(list);
> + free(objects);
> +
> + gem_close(i915, batch);
> +}
> +
> +static void fill_params(int i915, struct params *params,
> + struct drm_i915_memory_region_info *region,
> + unsigned int flags,
> + unsigned int nproc,
> + bool do_oom_test)
> +{
> + const int swap_mb = /* For lmem, swap is total of smem + swap. */
> + intel_get_total_ram_mb() + intel_get_total_swap_mb();
> + const unsigned int size = 1 << 20;
> + const int max_swap_pct = 75;
> + /*
> + * In random mode, add 85% hard limit to use system memory.
> + * noticed that 88.8% can trigger OOM on some system.
> + */
> + const int mem_limit_pct = 85;
> + int spill_mb;
> + uint32_t handle;
> +
> + if (flags & TEST_RANDOM) {
> + params->size.min = 4096;
> + handle = create_bo(i915, params->size.min, ®ion->region,
> + do_oom_test);
> + gem_close(i915, handle);
> + params->size.max = 2 * size + params->size.min;
> + } else {
> + params->size.min = size;
> + params->size.max = size;
> + }
> +
> + params->count = (region->probed_size + (size - 1)) / size * 3 / 2;
> + spill_mb = (size >> 20) * params->count - (region->probed_size >> 20);
> + /* Don't use all RAM for swapout. */
> + igt_require(spill_mb <= swap_mb * max_swap_pct / 100);
> +
> + if (flags & TEST_HEAVY) {
> + params->count *= 2;
> + spill_mb = (size >> 20) * params->count -
> + (region->probed_size >> 20);
> +
> + if (spill_mb > swap_mb * max_swap_pct / 100) {
> + unsigned int count;
> + unsigned long set;
> +
> + igt_warn("Reducing working set due low RAM + swap! (Need %d MiB, have %d MiB.)\n",
> + spill_mb, swap_mb);
> + set = region->probed_size +
> + (((unsigned long)swap_mb * max_swap_pct / 100) << 20);
> + count = set / size;
> + /* No point if heavy test is too similar to normal. */
> + igt_require(count > (params->count / 2) * 133 / 100);
> + params->count = count;
> + }
> + }
> +
> + params->loops = params->count;
> + params->seed = opt.user_seed ? opt.seed : time(NULL);
> +
> + /*
> + * If run in parallel, reduce per process buffer count to keep the
> + * total the same, but don't reduce loops since we gain some
> + * efficiency by the parallel execution
> + */
> + if (flags & TEST_PARALLEL)
> + params->count /= nproc;
> +
> + /*
> + * For heavy tests, reduce the loop count to avoid excessive
> + * run-times
> + */
> + if (flags & TEST_HEAVY)
> + params->loops = params->loops / 2 + 1;
> +
> + params->flags = flags;
> + params->oom_test = do_oom_test;
> +
> + params->mem_limit = swap_mb * mem_limit_pct / 100 +
> + (region->probed_size >> 20);
> + igt_info("Memory: system-total %dMiB, lmem-region %lldMiB, usage-limit %dMiB\n",
> + swap_mb, (region->probed_size >> 20), params->mem_limit);
> + igt_info("Using %u thread(s), %u loop(s), %u objects of %lu %s - %lu %s, seed: %u, oom: %s\n",
> + params->flags & TEST_PARALLEL ? nproc : 1,
> + params->loops,
> + params->count,
> + readable_size(params->size.min),
> + readable_unit(params->size.min),
> + readable_size(params->size.max),
> + readable_unit(params->size.max),
> + params->seed,
> + do_oom_test ? "yes" : "no");
> +}
> +
> +static void test_evict(int i915,
> + struct drm_i915_memory_region_info *region,
> + unsigned int flags)
> +{
> + const unsigned int nproc = sysconf(_SC_NPROCESSORS_ONLN) + 1;
> + struct params params;
> +
> + fill_params(i915, ¶ms, region, flags, nproc, false);
> +
> + if (flags & TEST_PARALLEL) {
> + int fd = gem_reopen_driver(i915);
> +
> + igt_fork(child, nproc)
> + __do_evict(fd, ®ion->region, ¶ms,
> + params.seed + child + 1);
> +
> + igt_waitchildren();
> + close(fd);
> + } else {
> + __do_evict(i915, ®ion->region, ¶ms, params.seed);
> + }
> +}
> +
> +static void leak(uint64_t alloc)
> +{
> + char *ptr;
> +
> + ptr = mmap(NULL, alloc, PROT_READ | PROT_WRITE,
> + MAP_ANON | MAP_PRIVATE | MAP_POPULATE, -1, 0);
> + if (ptr == MAP_FAILED)
> + return;
> +
> + while (alloc) {
> + alloc -= 4096;
> + ptr[alloc] = 0;
> + }
> +}
> +
> +static void gem_leak(int fd, uint64_t alloc)
> +{
> + uint32_t handle = gem_create(fd, alloc);
> + void *buf;
> +
> + buf = gem_mmap_offset__fixed(fd, handle, 0, PAGE_SIZE, PROT_WRITE);
> + memset(buf, 0, PAGE_SIZE);
> + munmap(buf, PAGE_SIZE);
> +
> + gem_madvise(fd, handle, I915_MADV_DONTNEED);
Don't know if it matters much, but this doesn't really "leak" anything
AFAIK. It just allocates the pages and then drops them immediately in
the madvise, due to differences in how the mmap works in the ttm vs
the old stuff(the ttm fault handler doesn't currently set the
mm.pages). I guess it depends on what the original meaning of this
"gem_leak" was.
Anyway,
Reviewed-by: Matthew Auld <matthew.auld at intel.com>
> +}
> +
> +static int *lmem_done;
> +
> +static void smem_oom_exit_handler(int sig)
> +{
> + (*lmem_done)++;
> +}
> +
> +static void test_smem_oom(int i915,
> + struct drm_i915_memory_region_info *region)
> +{
> + const uint64_t smem_size = intel_get_total_ram_mb() +
> + intel_get_total_swap_mb();
> + const unsigned int alloc = 256 * 1024 * 1024;
> + const unsigned int num_alloc = 1 + smem_size / (alloc >> 20);
> + struct igt_helper_process smem_proc = {};
> + unsigned int n;
> +
> + lmem_done = mmap(0, sizeof(*lmem_done), PROT_WRITE,
> + MAP_SHARED | MAP_ANON, -1, 0);
> + igt_assert(lmem_done != MAP_FAILED);
> + *lmem_done = 0;
> +
> + /* process for testing lmem eviction */
> + igt_fork(child, 1) {
> + int fd = gem_reopen_driver(i915);
> + struct params params;
> +
> + fill_params(i915, ¶ms, region, 0, 1, true);
> +
> + igt_install_exit_handler(smem_oom_exit_handler);
> + __do_evict(fd, ®ion->region, ¶ms,
> + params.seed + child + 1);
> +
> + close(fd);
> + }
> +
> + /* smem memory hog process, respawn till the lmem process completes */
> + while (!READ_ONCE(*lmem_done)) {
> + igt_fork_helper(&smem_proc) {
> + igt_fork(child, 1) {
> + for (int pass = 0; pass < num_alloc; pass++) {
> + if (READ_ONCE(*lmem_done))
> + break;
> + leak(alloc);
> + }
> + }
> + igt_fork(child, 1) {
> + int fd = gem_reopen_driver(i915);
> +
> + for (int pass = 0; pass < num_alloc; pass++) {
> + if (READ_ONCE(*lmem_done))
> + break;
> + gem_leak(fd, alloc);
> + }
> + close(fd);
> + }
> + /*
> + * Wait for grand-child processes to finish or be
> + * killed by the oom killer, don't call
> + * igt_waitchildren because of the noise
> + */
> + for (n = 0; n < 2; n++)
> + wait(NULL);
> + }
> + igt_wait_helper(&smem_proc);
> + }
> + munmap(lmem_done, sizeof(*lmem_done));
> + /* Reap exit status of the lmem process */
> + igt_waitchildren();
> +}
> +
> +#define dynamic_lmem_subtest(reg, regs, subtest_name...) \
> + igt_subtest_with_dynamic(subtest_name) \
> + for (unsigned int i = 0; i < (regs)->num_regions; i++) \
> + for_each_if (((reg) = &(regs)->regions[i])->region.memory_class == I915_MEMORY_CLASS_DEVICE) \
> + igt_dynamic_f("lmem%u", (reg)->region.memory_instance)
> +
> +static int opt_handler(int option, int option_index, void *input)
> +{
> + switch (option) {
> + case 's':
> + opt.user_seed = true;
> + opt.seed = strtoul(optarg, NULL, 0);
> + break;
> + default:
> + return IGT_OPT_HANDLER_ERROR;
> + }
> +
> + return IGT_OPT_HANDLER_SUCCESS;
> +}
> +
> +const char *help_str =
> + " --seed Seed for random number generator";
> +
> +struct option long_options[] = {
> + { "seed", required_argument, NULL, 's'},
> + { 0, 0, 0, 0 }
> +};
> +
> +igt_main_args("", long_options, help_str, opt_handler, NULL)
> +{
> + struct drm_i915_query_memory_regions *regions;
> + struct drm_i915_memory_region_info *region;
> + struct test {
> + const char *name;
> + unsigned int flags;
> + } *test, tests[] = {
> + { "basic", 0 },
> + { "random", TEST_RANDOM },
> + { "random-engines", TEST_RANDOM | TEST_ENGINES },
> + { "heavy-random", TEST_RANDOM | TEST_HEAVY },
> + { "heavy-multi", TEST_RANDOM | TEST_HEAVY | TEST_ENGINES | TEST_MULTI },
> + { "verify", TEST_VERIFY},
> + { "verify-random", TEST_VERIFY | TEST_RANDOM},
> + { "heavy-verify-random", TEST_VERIFY | TEST_RANDOM | TEST_HEAVY },
> + { "heavy-verify-multi", TEST_VERIFY | TEST_RANDOM | TEST_HEAVY | TEST_ENGINES | TEST_MULTI },
> + { "parallel-random", TEST_PARALLEL | TEST_RANDOM },
> + { "parallel-random-engines", TEST_PARALLEL | TEST_RANDOM | TEST_ENGINES },
> + { "parallel-random-verify", TEST_PARALLEL | TEST_RANDOM | TEST_VERIFY },
> + { "parallel-multi", TEST_PARALLEL | TEST_RANDOM | TEST_VERIFY | TEST_ENGINES | TEST_MULTI },
> + { }
> + };
> + int i915 = -1;
> +
> + igt_fixture {
> + struct intel_execution_engine2 *e;
> +
> + i915 = drm_open_driver(DRIVER_INTEL);
> + igt_require_gem(i915);
> +
> + regions = gem_get_query_memory_regions(i915);
> + igt_require(regions);
> +
> + for_each_physical_engine(i915, e)
> + __num_engines__++;
> + igt_require(__num_engines__);
> + }
> +
> + for (test = tests; test->name; test++) {
> + igt_describe("Exercise local memory swapping to system memory");
> + dynamic_lmem_subtest(region, regions, test->name)
> + test_evict(i915, region, test->flags);
> + }
> +
> + igt_describe("Exercise local memory swapping during exhausting system memory");
> + dynamic_lmem_subtest(region, regions, "smem-oom")
> + test_smem_oom(i915, region);
> +
> + igt_fixture {
> + free(regions);
> + close(i915);
> + }
> +
> + igt_exit();
> +}
> diff --git a/tests/meson.build b/tests/meson.build
> index 0af3e03a3..49c0f2d24 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -156,6 +156,7 @@ i915_progs = [
> 'gem_gtt_speed',
> 'gem_huc_copy',
> 'gem_linear_blits',
> + 'gem_lmem_swapping',
> 'gem_lut_handle',
> 'gem_madvise',
> 'gem_media_fill',
> --
> 2.26.0
>
More information about the igt-dev
mailing list