[igt-dev] ✗ Fi.CI.BAT: failure for tests/amdgpu: Introduces DP DSC test

[Rodrigo Siqueira Jordao]

Hi Petri/Lakshmi,

Thanks a lot for your help with this issue.

Petri/Lakshmi, the only generic change that this patch made is in the 
`enum igt_atomic_crtc_properties` as described in the below diff:

--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -125,6 +125,7 @@ enum igt_atomic_crtc_properties {
         IGT_CRTC_ACTIVE,
         IGT_CRTC_OUT_FENCE_PTR,
         IGT_CRTC_VRR_ENABLED,
+       IGT_CRTC_DSC_SLICE_HEIGHT,
         IGT_NUM_CRTC_PROPS
  };

Please, correct me if I'm wrong, but from the CI report this patch might 
cause issues in the following subtests:

Possible regressions
igt at kms_frontbuffer_tracking@fbc-tiling-y:

shard-iclb: PASS -> FAIL +803 similar issues
igt at kms_plane@plane-panning-bottom-right:

shard-iclb: NOTRUN -> FAIL +159 similar issues
igt at kms_prime@basic-crc at second-to-first:

shard-iclb: PASS -> CRASH +4 similar issues

(https://patchwork.freedesktop.org/series/97325/)

 From the above list, the only test that I can try to reproduce on my 
end is igt at kms_plane@plane-panning-bottom-right which works fine with 
this patch or not. Additionally, it looks like that all failures in this 
shard-iclb machine has:

	
Received signal SIGSEGV.
Stack trace:
  #0 [fatal_sig_handler+0xd6]
  #1 [killpg+0x40]
  #2 [__nss_database_lookup+0x20792]
  #3 [igt_display_require+0x62a]
  #4 [__igt_unique____real_main1225+0xc1]
  #5 [main+0x3f]
  #6 [__libc_start_main+0xf3]
  #7 [_start+0x2a]
(https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6442/shard-iclb3/igt@kms_plane@plane-panning-bottom-right.html)

 From the above error, I expected that I could reproduce this type of 
issue on my side. Additionally, when I looked at the shard-iclb machine 
((https://intel-gfx-ci.01.org/hardware.html)), I noticed it is an Ice 
lake machine connected to a single eDP display (I suppose it is a 
laptop). If this patch introduces such a regression, I guess we have a 
bug in some of the igt_kms functions.

I don't have an Ice Lake machine for trying to reproduce this issue on 
my side; in this sense, do you have any suggestions? Is this error 
generic across Intel devices? Or only that specific machine? I think I 
can try to remove that property from igt_kms and make it only available 
inside the AMD test, but I'm not sure if this is the right approach.

Thanks

On 2021-11-30 4:50 a.m., Petri Latvala wrote:
> No, no, no. These failures are definitely caused by the patch
> series. Even though it's "focused" on amdgpu tests, you're changing
> igt_kms.h in a way that causes crashes and whatnot.
> 
> 
> On Tue, Nov 30, 2021 at 12:20:19AM +0000, Vudum, Lakshminarayana wrote:
>> Not sure what's really happening with this series, I haven't seen similar failures on post-merge with these signatures.
>> I have updated the filter https://gitlab.freedesktop.org/drm/intel/-/issues/4638 to catch all similar failures from TGL and RKL.
> 
> Lakshmi, please revert that filter change.
> 
> 
>