[igt-dev] [PATCH i-g-t] tests/kms_hdr: Fix failure to read output_bpc on AMD hardware

[Rodrigo Siqueira]

On 10/04, Petri Latvala wrote:
> On Sat, Oct 02, 2021 at 11:15:11AM -0400, Rodrigo Siqueira wrote:
> > Hi Lakshminarayana and Petri,
> > 
> > I noticed that the CI was not triggered for this patch [1]. Do you know
> > why? Is it possible to trigger it?
> > 
> > 1. https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.freedesktop.org%2Fseries%2F95313%2F&data=04%7C01%7CRodrigo.Siqueira%40amd.com%7C43b5d7ab0731407a2f9008d987278e48%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637689426230154758%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=NIEF78%2B74hVRdQPhcCEPVlp4To3iDjkpkkv8VjSC0%2BE%3D&reserved=0
> 
> CI was down for a bit due to server cert issues, testing that and the
> other affected series happening in a bit.

Thanks Petri,

I noticed that the CI was triggered for this patch.

Lakshminarayana,

It looks like that we have a false positive	in the result:

  https://patchwork.freedesktop.org/series/95313/

Notice that this patch only changes kms_hdr, but we have a failure in
the igt at kms_lease.

Thanks
Siqueira
 
> 
> -- 
> Petri Latvala
> 
> 
> > 
> > Thanks
> > Siqueira
> > 
> > On 10/01, Stylon Wang wrote:
> > > The first commit with TEST_ONLY flag in bpc-switch subtests
> > > could in some cases cause reading of output_bpc on connectors
> > > to fail on AMD hardware.
> > > 
> > > Use ALLOW_MODESET to prevent this from happening.
> > > 
> > > Signed-off-by: Stylon Wang <stylon.wang at amd.com>
> > > ---
> > >  tests/kms_hdr.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/tests/kms_hdr.c b/tests/kms_hdr.c
> > > index 5b8529c8..a4983b9a 100644
> > > --- a/tests/kms_hdr.c
> > > +++ b/tests/kms_hdr.c
> > > @@ -217,7 +217,7 @@ static void test_bpc_switch_on_output(data_t *data, igt_output_t *output,
> > >  		igt_plane_set_fb(data->primary, &afb);
> > >  		igt_plane_set_size(data->primary, data->w, data->h);
> > >  		igt_output_set_prop_value(data->output, IGT_CONNECTOR_MAX_BPC, 8);
> > > -		ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_TEST_ONLY, NULL);
> > > +		ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
> > >  		if (!ret) {
> > >  			data->w = afb.width;
> > >  			data->h = afb.height;
> > > -- 
> > > 2.32.0
> > > 
> > 
> > -- 
> > Rodrigo Siqueira
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsiqueira.tech%2F&data=04%7C01%7CRodrigo.Siqueira%40amd.com%7C43b5d7ab0731407a2f9008d987278e48%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637689426230154758%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=VvCEWNlBkZnAm9M1JYeheIlVaUVMkeDiallVz0uUM8o%3D&reserved=0

-- 
Rodrigo Siqueira
https://siqueira.tech