[igt-dev] [PATCH i-g-t] tests/core_hotunplug: Drop log level for preventively unloading snd driver

Shankar, Uma uma.shankar at intel.com
Tue Oct 5 04:59:35 UTC 2021



> -----Original Message-----
> From: B, Jeevan <jeevan.b at intel.com>
> Sent: Thursday, September 23, 2021 12:15 PM
> To: igt-dev at lists.freedesktop.org
> Cc: Shankar, Uma <uma.shankar at intel.com>; B, Jeevan <jeevan.b at intel.com>
> Subject: [PATCH i-g-t] tests/core_hotunplug: Drop log level for preventively
> unloading snd driver
> 
> change igt_warn to igt_info when unloading the snd module before unbinding i915
> until WA is fixed. As this "todo reminder" is flagged as BAT failure and showing up in
> all sorts of top-bugs lists for various platforms.

Seems ok to clear the BAT noise, till the proper fix is done in audio driver.
Reviewed-by: Uma Shankar <uma.shankar at intel.com>

Note: Since this is a v2, you should add this and what changed in this version.

> Signed-off-by: Jeevan B <jeevan.b at intel.com>
> ---
>  tests/core_hotunplug.c | 2 +-
>  tests/device_reset.c   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c index
> 2d73e27f..b3661668 100644
> --- a/tests/core_hotunplug.c
> +++ b/tests/core_hotunplug.c
> @@ -164,7 +164,7 @@ static void driver_unbind(struct hotunplug *priv, const char
> *prefix,
>  			igt_lsof("/dev/snd");
>  			igt_skip("Audio is in use, skipping\n");
>  		} else {
> -			igt_warn("Preventively unloaded snd_hda_intel\n");
> +			igt_info("Preventively unloaded snd_hda_intel\n");
>  		}
>  	}
> 
> diff --git a/tests/device_reset.c b/tests/device_reset.c index e6a468e6..982ba5ef
> 100644
> --- a/tests/device_reset.c
> +++ b/tests/device_reset.c
> @@ -201,7 +201,7 @@ static void driver_unbind(struct device_fds *dev)
>  			igt_lsof("/dev/snd");
>  			igt_skip("Audio is in use, skipping\n");
>  		} else {
> -			igt_warn("Preventively unloaded snd_hda_intel\n");
> +			igt_info("Preventively unloaded snd_hda_intel\n");
>  		}
>  	}
> 
> --
> 2.19.1



More information about the igt-dev mailing list