[igt-dev] [PATCH i-g-t v13 01/16] i915_drm.h sync PXP default session

Teres Alexis, Alan Previn alan.previn.teres.alexis at intel.com
Tue Oct 5 19:31:31 UTC 2021


Hey Rodrigo, apologies for this upstream-newbie mistake and I truly appreciate you taking the time and explaining my mistake especially the pull-in of the other non-PXP delta's too. I will respin this ASAP.

...alan

-----Original Message-----
From: Vivi, Rodrigo <rodrigo.vivi at intel.com> 
Sent: Tuesday, October 5, 2021 12:15 PM
To: Teres Alexis, Alan Previn <alan.previn.teres.alexis at intel.com>
Cc: igt-dev at lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v13 01/16] i915_drm.h sync PXP default session

On Tue, Oct 05, 2021 at 08:10:07AM -0700, Alan Previn wrote:
> Sync UAPI for to get I915_PROTECTED_CONTENT_DEFAULT_SESSION define value.
> 
> Taken from kernel commit:
> commit cbbd3764b2399ad882cda98435b25144e9ea2124
>        ("drm/i915/pxp: Create the arbitrary session after boot.")

This is not accurate. The i915_drm.h in this commit has more changes other than I915_PROTECTED_CONTENT_DEFAULT_SESSION.

We should combine the patches 1 and 2 of this series and make a simply i915_drm.h sync and add some reasoning in the commit message saying that it is because of the PXP. But the new include/drm-uapi/i915_drm.h should include all the new api additions from i915_drm.h uapi.


> 
> Signed-off-by: Alan Previn <alan.previn.teres.alexis at intel.com>
> ---
>  include/drm-uapi/i915_drm.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/drm-uapi/i915_drm.h b/include/drm-uapi/i915_drm.h 
> index b9632bb2..f4691fcc 100644
> --- a/include/drm-uapi/i915_drm.h
> +++ b/include/drm-uapi/i915_drm.h
> @@ -2990,6 +2990,9 @@ struct drm_i915_gem_create_ext_memory_regions {
>  	__u64 regions;
>  };
>  
> +/* ID of the protected content session managed by i915 when PXP is 
> +active */ #define I915_PROTECTED_CONTENT_DEFAULT_SESSION 0xf
> +
>  #if defined(__cplusplus)
>  }
>  #endif
> --
> 2.25.1
> 


More information about the igt-dev mailing list