[igt-dev] [PATCH i-g-t 1/8] tests/i915/gem_pxp: Add LOCAL_ UAPI defines

Rodrigo Vivi rodrigo.vivi at intel.com
Wed Oct 6 17:25:25 UTC 2021


On Wed, Oct 06, 2021 at 10:17:41AM -0700, Dixit, Ashutosh wrote:
> On Wed, 06 Oct 2021 09:14:37 -0700, Rodrigo Vivi wrote:
> >
> > While the UAPI changes don't propagate to drm-next we should
> > have that as LOCAL_ ones.
> 
> Please add these in lib/i915/i915_drm_local.h as follows:

Could we move this file to the include directory and document it
in the README.md along with the uapi sync mention?

> 
> /*
>  * It is necessary on occasion to add uapi declarations to IGT before they
>  * appear in imported kernel uapi headers. This header is provided for this
>  * purpose.
> 
>  * Early uapi declarations should be added here exactly as they are
>  * expected to appear in the kernel uapi headers, i.e. without the LOCAL_
>  * or local_ prefix and without any #ifndef's. Attempt should be made to
>  * clean these up when kernel uapi headers are sync'd.
>  */
> 
> >
> > That was my mistake during review and merge since I had
> > ignored the rules documented at README.md and considered
> > drm-intel branches would be enough. I'm sorry.
> >
> > Cc: Alan Previn <alan.previn.teres.alexis at intel.com>
> > Cc: Petri Latvala <petri.latvala at intel.com>
> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>


More information about the igt-dev mailing list