[igt-dev] [PATCH i-g-t 3/7] tests/gem_exec_alignment: Add prerequisite alignment condition

Zbigniew Kempczyński zbigniew.kempczynski at intel.com
Thu Oct 14 07:27:00 UTC 2021


On Wed, Oct 13, 2021 at 09:12:36PM -0700, Dixit, Ashutosh wrote:
> On Thu, 07 Oct 2021 23:54:28 -0700, Zbigniew Kempczyński wrote:
> >
> > Skip the test if the kernel doesn't support passing object alignment.
> >
> > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> > Cc: Petri Latvala <petri.latvala at intel.com>
> > Cc: Ashutosh Dixit <ashutosh.dixit at intel.com>
> > ---
> >  tests/i915/gem_exec_alignment.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tests/i915/gem_exec_alignment.c b/tests/i915/gem_exec_alignment.c
> > index c4611bd1e..f40b391c9 100644
> > --- a/tests/i915/gem_exec_alignment.c
> > +++ b/tests/i915/gem_exec_alignment.c
> > @@ -530,6 +530,7 @@ igt_main
> >	igt_fixture {
> >		fd = drm_open_driver(DRIVER_INTEL);
> >		igt_require_gem(fd);
> > +		igt_require(gem_allows_passing_alignment(fd));
> 
> How about renaming this function something like gem_allows_obj_alignment?
> Otherwise this is:

Yes, I like this name - it is much better than mine. I'll fix and resend.

--
Zbigniew

> 
> Reviewed-by: Ashutosh Dixit <ashutosh.dixit at intel.com>


More information about the igt-dev mailing list