[igt-dev] [PATCH i-g-t 6/7] tests/i915/kms_frontbuffer_tracking: Use preferred modes's vrefresh

Modem, Bhanuprakash bhanuprakash.modem at intel.com
Mon Oct 18 05:02:11 UTC 2021


> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Ville
> Syrjala
> Sent: Wednesday, October 13, 2021 6:30 PM
> To: igt-dev at lists.freedesktop.org
> Subject: [igt-dev] [PATCH i-g-t 6/7] tests/i915/kms_frontbuffer_tracking: Use
> preferred modes's vrefresh
> 
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> i915 will reject custom modes that don't match the laptop
> panel's fixed mode refresh rate. Thus we must generate
> our override modes with a matching refresh rate.
> 
> https://gitlab.freedesktop.org/drm/intel/-/issues/4283
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

LGTM
Reviewed-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>

- Bhanu

> ---
>  tests/i915/kms_frontbuffer_tracking.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/i915/kms_frontbuffer_tracking.c
> b/tests/i915/kms_frontbuffer_tracking.c
> index 2a1ed5f52e37..d6a884926c48 100644
> --- a/tests/i915/kms_frontbuffer_tracking.c
> +++ b/tests/i915/kms_frontbuffer_tracking.c
> @@ -313,7 +313,7 @@ static drmModeModeInfo
> *get_connector_smallest_mode(igt_output_t *output)
>  	int i;
> 
>  	if (c->connector_type == DRM_MODE_CONNECTOR_eDP)
> -		return igt_std_1024_mode_get(60);
> +		return
> igt_std_1024_mode_get(igt_output_preferred_vrefresh(output));
> 
>  	for (i = 0; i < c->count_modes; i++) {
>  		const drmModeModeInfo *mode = &c->modes[i];
> @@ -336,7 +336,7 @@ static drmModeModeInfo *connector_get_mode(igt_output_t
> *output)
>  	  * bugged. */
>  	if (IS_HASWELL(intel_get_drm_devid(drm.fd)) &&
>  	    output->config.connector->connector_type == DRM_MODE_CONNECTOR_eDP)
> -		return igt_std_1024_mode_get(60);
> +		return
> igt_std_1024_mode_get(igt_output_preferred_vrefresh(output));
> 
>  	if (opt.small_modes)
>  		return get_connector_smallest_mode(output);
> --
> 2.32.0



More information about the igt-dev mailing list