[igt-dev] [PATCH i-g-t] tests/kms_plane_multiple: Use same modifier for reference crc as for test crc

[Juha-Pekka Heikkila]

On 20.10.2021 15.03, Ville Syrjälä wrote:
> On Wed, Oct 20, 2021 at 12:12:38PM +0300, Juha-Pekka Heikkila wrote:
>> Create reference crc with same modifier as is used for testing. This
>> will reduce non test related anomalies.
>>
>> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
>> ---
>>   tests/kms_plane_multiple.c | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c
>> index ece00097e..30e4bcc0d 100644
>> --- a/tests/kms_plane_multiple.c
>> +++ b/tests/kms_plane_multiple.c
>> @@ -111,10 +111,13 @@ get_reference_crc(data_t *data, igt_output_t *output, enum pipe pipe,
>>   
>>   	igt_create_color_fb(data->drm_fd, mode->hdisplay, mode->vdisplay,
>>   			    DRM_FORMAT_XRGB8888,
>> -			    DRM_FORMAT_MOD_LINEAR,
>> +			    modifier,
>>   			    color->red, color->green, color->blue,
>>   			    &data->fb[primary->index]);
>>   
>> +	igt_skip_on(!igt_plane_has_format_mod(data->plane[primary->index],
>> +		    DRM_FORMAT_XRGB8888, modifier));
>> +
> 
> Maybe do that before the create_fb()?

Yep, I misplaced that. CI results also talk about that. I'll move it 
above create_fb and push.

> 
> Otherwise seems fine.
> Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
>>   	igt_plane_set_fb(data->plane[primary->index], &data->fb[primary->index]);
>>   
>>   	ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
>> -- 
>> 2.28.0
>