[igt-dev] [PATCH i-g-t 1/2] lib/igt_fb: create i915 bo in lmem, if available

Maarten Lankhorst maarten.lankhorst at linux.intel.com
Wed Oct 20 13:29:47 UTC 2021


Op 19-10-2021 om 12:02 schreef Ville Syrjälä:
> On Tue, Oct 19, 2021 at 11:40:29AM +0200, Maarten Lankhorst wrote:
>> create_bo_for_fb() should call gem_buffer_create_fb_obj, as this is the
>> function used to create an object in lmem. This will fix the
>> kms_frontbuffer_tracking tests failing on DG1.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
>> ---
>>  lib/igt_fb.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
>> index 63f3c86e75f0..216b1d5c4aff 100644
>> --- a/lib/igt_fb.c
>> +++ b/lib/igt_fb.c
>> @@ -1092,7 +1092,7 @@ static int create_bo_for_fb(struct igt_fb *fb, bool prefer_sysmem)
>>  		if (is_i915_device(fd)) {
>>  			int err;
>>  
>> -			fb->gem_handle = gem_create(fd, fb->size);
>> +			fb->gem_handle = gem_buffer_create_fb_obj(fd, fb->size);
> Looks to do what we need.
>
> Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
>>  			err = __gem_set_tiling(fd, fb->gem_handle,
>>  					       igt_fb_mod_to_tiling(fb->modifier),
>>  					       fb->strides[0]);
>> -- 
>> 2.33.0

Thanks, pushed this patch & second amended patch. :)

Now DG1 crashes on FBC properly.

~Maarten



More information about the igt-dev mailing list