[igt-dev] [PATCH i-g-t 1/8] tests/i915/gem_exec_capture: Remove pointless assert
John.C.Harrison at Intel.com
John.C.Harrison at Intel.com
Thu Oct 21 23:40:37 UTC 2021
From: John Harrison <John.C.Harrison at Intel.com>
The 'many' test ended with an 'assert(count)', presumably meaning to
ensure that some objects were actually captured. However, 'count' is
the number of objects created not how many were captured. Plus, there
is already a 'require(count > 1)' at the start and count is invarient
so the final assert is basically pointless.
General concensus appears to be that the test should not fail
irrespective of how many blobs are captured as low memory situations
could cause the capture to be abbreviated. So just remove the
pointless assert completely.
Signed-off-by: John Harrison <John.C.Harrison at Intel.com>
---
tests/i915/gem_exec_capture.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/i915/gem_exec_capture.c b/tests/i915/gem_exec_capture.c
index 7e0a8b8ad..53649cdb2 100644
--- a/tests/i915/gem_exec_capture.c
+++ b/tests/i915/gem_exec_capture.c
@@ -524,7 +524,6 @@ static void many(int fd, int dir, uint64_t size, unsigned int flags)
}
igt_info("Captured %lu %"PRId64"-blobs out of a total of %lu\n",
blobs, size >> 12, count);
- igt_assert(count);
free(error);
free(offsets);
--
2.25.1
More information about the igt-dev
mailing list