[igt-dev] [PATCH i-g-t v2 2/4] tests/kms_psr2_su: Set the damaged clip in page flips

Gwan-gyeong Mun gwan-gyeong.mun at intel.com
Thu Sep 2 19:32:44 UTC 2021


Looks good to me.
Reviewed-by: Gwan-gyeong Mun <gwan-gyeong.mun at intel.com>

On 8/19/21 1:24 AM, José Roberto de Souza wrote:
> Without this i915 will not know what was updated in the screen and
> update the whole plane causing mismatch between the read SU blocks and
> the expected value when PSR2 selective fetch is enabled.
> 
> Cc: Gwan-gyeong Mun <gwan-gyeong.mun at intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza at intel.com>
> ---
>   tests/kms_psr2_su.c | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/tests/kms_psr2_su.c b/tests/kms_psr2_su.c
> index a232b3bb4..318deefdf 100644
> --- a/tests/kms_psr2_su.c
> +++ b/tests/kms_psr2_su.c
> @@ -149,11 +149,17 @@ static bool update_screen_and_test(data_t *data)
>   
>   	switch (data->op) {
>   	case PAGE_FLIP: {
> +		struct drm_mode_rect clip;
>   		igt_plane_t *primary;
>   
> +		clip.x1 = clip.y1 = 0;
> +		clip.x2 = clip.y2 = SQUARE_SIZE;
> +
>   		primary = igt_output_get_plane_type(data->output,
>   						    DRM_PLANE_TYPE_PRIMARY);
>   
> +		igt_plane_replace_prop_blob(primary, IGT_PLANE_FB_DAMAGE_CLIPS,
> +					    &clip, sizeof(clip));
>   		igt_plane_set_fb(primary, &data->fb[data->screen_changes & 1]);
>   		igt_display_commit2(&data->display, COMMIT_ATOMIC);
>   		break;
> 


More information about the igt-dev mailing list