[igt-dev] [PATCH i-g-t v9 01/16] Add PXP UAPI support in i915_drm.h

[Dixit, Ashutosh]

On Sun, 05 Sep 2021 23:21:42 -0700, Petri Latvala wrote:
>
> On Sat, Sep 04, 2021 at 12:11:47AM +0300, Teres Alexis, Alan Previn wrote:
> > oops - my bad - didnt realize we had that - will do.
> >
> > While on this, would it make sense to permanently include
> > lib/i915/i915_drm_local.h from include/drm- uapi/i915_drm.h (but latter
> > would always remain empty on upstream)?. This way, when kernel support
> > is added for UAPI changes, we move the definitions across but dont add
> > and need remove the '#include "lib/i915/i915_drm_local.h" from the
> > other source files (requiring another change)?
>
> It would, but it's impossible. include/drm-uapi/i915_drm.h is supposed
> to be a pristine unchanged drop from the kernel.
>
> The other way around might work but looks more odd from the .c side.

But each source file does not have to include i915_drm_local.h since it is
included in igt_gt.h. So as long as igt_gt.h is included (which should be,
directly or indirectly) i915_drm_local.h is automatically included and does
not have to be explicitly included.