[igt-dev] [PATCH i-g-t v2 1/4] tests/kms_cursor_legacy: Handle cursor movements as slow patch for display 9+

[Souza, Jose]

On Wed, 2021-09-08 at 12:47 +0300, Petri Latvala wrote:
> On Tue, Sep 07, 2021 at 11:01:27AM -0700, José Roberto de Souza wrote:
> > i915 is dropping frontbuffer rendering support for display 9+ so
> > this evasion attempts will never happen as DRM_IOCTL_MODE_CURSOR will
> > be converted to atomic commits that will be executed during vblanks.
> > 
> > v2:
> > - Not using data filed by fixture to generate subtest list (Petri)
> > 
> > Cc: Petri Latvala <petri.latvala at intel.com>
> > Cc: Gwan-gyeong Mun <gwan-gyeong.mun at intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza at intel.com>
> > ---
> >  tests/kms_cursor_legacy.c | 24 ++++++++++++++----------
> >  1 file changed, 14 insertions(+), 10 deletions(-)
> > 
> > diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
> > index 0f0df951b..3ddea9c35 100644
> > --- a/tests/kms_cursor_legacy.c
> > +++ b/tests/kms_cursor_legacy.c
> > @@ -303,8 +303,13 @@ enum flip_test {
> >  	flip_test_last = flip_test_atomic_transitions_varying_size
> >  };
> >  
> > -static bool cursor_slowpath(enum flip_test mode)
> > +static bool cursor_slowpath(igt_display_t *display, enum flip_test mode)
> >  {
> > +	/* Intel display 9 and newer will handle cursor movement as fastsets */
> > +	if (is_i915_device(display->drm_fd) &&
> > +	    intel_display_ver(intel_get_drm_devid(display->drm_fd)) >= 9)
> > +	    return true;
> 
> 
> What is the meaning of the return value of cursor_slowpath()? "This
> will take the slow path"? If so, the comment and the code are saying
> opposite things...

The slow path is a fastset, the 'fast path' would be do a front buffer rendering but the second is being dropped for SKL+.

> 
>