[igt-dev] [PATCH i-g-t] tests/kms_addfb_basic: Skip basic-y-tiled-legacy on discrete

[Imre Deak]

On Mon, Sep 13, 2021 at 09:55:50AM -0700, Ashutosh Dixit wrote:
> The test will fail on discrete and needs to be skipped.
> 
> Cc: Imre Deak <imre.deak at intel.com>
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit at intel.com>
> ---
>  tests/kms_addfb_basic.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
> index 0f641e7dd78..eed7038c39d 100644
> --- a/tests/kms_addfb_basic.c
> +++ b/tests/kms_addfb_basic.c
> @@ -393,6 +393,7 @@ static void tiling_tests(int fd)
>  		igt_describe("Test that addfb2 call fails correctly for basic y-tiling test");
>  		f.pitches[0] = 1024*4;
>  		igt_subtest("basic-y-tiled-legacy") {
> +			igt_require(!gem_has_lmem(fd));

Ah yes, it's possible to add a y-tiled FB using an object which doesn't
have a tiling set on it (and the object tiling can't be set on !lmem).
Sorry for missing that:

Reviewed-by: Imre Deak <imre.deak at intel.com>

>  			f.handles[0] = tiled_y_bo;
>  
>  			igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == -1 &&
> -- 
> 2.31.1
>