[igt-dev] [PATCH i-g-t] tests/kms_color_chamelium: Skip CTM test if property is not present

Sharma, Swati2 swati2.sharma at intel.com
Tue Sep 14 12:37:51 UTC 2021


LGTM. However, we need to add fixes tag. Once bug is filed; can you please
float another version with that tag?

Reviewed-by:  Swati Sharma <swati2.sharma at intel.com>

On 14-Sep-21 4:55 PM, Bhanuprakash Modem wrote:
> CRTC property "CTM" is required for all CTM tests.
> 
> Cc: Uma Shankar <uma.shankar at intel.com>
> Cc: Swati Sharma <swati2.sharma at intel.com>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
> ---
>   tests/kms_color_chamelium.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tests/kms_color_chamelium.c b/tests/kms_color_chamelium.c
> index bc4356bfa..7173bc69e 100644
> --- a/tests/kms_color_chamelium.c
> +++ b/tests/kms_color_chamelium.c
> @@ -398,6 +398,8 @@ static void test_pipe_limited_range_ctm(data_t *data,
>   	struct chamelium_port *port;
>   	char *connected_ports[4];
>   
> +	igt_require(igt_pipe_obj_has_prop(primary->pipe, IGT_CRTC_CTM));
> +
>   	degamma_linear = generate_table(data->degamma_lut_size, 1.0);
>   	gamma_linear = generate_table(data->gamma_lut_size, 1.0);
>   
> 

-- 
~Swati Sharma


More information about the igt-dev mailing list