[igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output

[Rodrigo Siqueira]

Hi Mark,

Yes, this patch cause a regression in AMD.

I applied the original patch after the CI reported a complete pass. I
also tested it in a VC4 and VKMS; just for curiosity, why did we not get
this regression in the CI?

Thanks

On 09/16, Mark Yacoub wrote:
> @Siquiera, I remember this also caused a regression on Qualcomm
> devices as well.
> Will removing this regress AMD? Any work around?
> 
> On Thu, Sep 16, 2021 at 10:30 AM Vidya Srinivas
> <vidya.srinivas at intel.com> wrote:
> >
> > Staring commit fea0e38e690c30c6 "Making the test more generic"
> > test_resolution_with_output introduced setting igt_output_set_pipe
> > to PIPE_NONE. This is triggering atomic check failure resulting in
> > "enabled/connectors mismatch" under drm_atomic_helper_check_modeset.
> > Patch fixes this issue.
> >
> > Signed-off-by: Vidya Srinivas <vidya.srinivas at intel.com>
> > ---
> >  tests/kms_concurrent.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
> > index 25c67eb469d1..40096ea1c457 100644
> > --- a/tests/kms_concurrent.c
> > +++ b/tests/kms_concurrent.c
> > @@ -268,7 +268,6 @@ test_resolution_with_output(data_t *data, enum pipe pipe, int max_planes, igt_ou
> >
> >                 /* switch to lower resolution */
> >                 igt_output_override_mode(output, mode_lo);
> > -               igt_output_set_pipe(output, PIPE_NONE);
> >                 igt_display_commit2(&data->display, COMMIT_ATOMIC);
> >
> >                 /* switch back to higher resolution */
> > --
> > 2.33.0
> >

-- 
Rodrigo Siqueira
https://siqueira.tech