[igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output

[Srinivas, Vidya]

> -----Original Message-----
> From: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> Sent: Thursday, September 23, 2021 11:26 PM
> To: Srinivas, Vidya <vidya.srinivas at intel.com>
> Cc: igt-dev at lists.freedesktop.org; Modem, Bhanuprakash
> <bhanuprakash.modem at intel.com>; markyacoub at google.com
> Subject: Re: [PATCH i-g-t] tests/kms_concurrent: Fix regression in
> test_resolution_with_output
> 
> On 09/20, Vidya Srinivas wrote:
> > Staring commit fea0e38e690c30c6 "Making the test more generic"
> > test_resolution_with_output introduced setting igt_output_set_pipe to
> > PIPE_NONE. This is triggering atomic check failure resulting in
> > "enabled/connectors mismatch" under
> drm_atomic_helper_check_modeset.
> > Patch fixes this issue.
> >
> > Signed-off-by: Vidya Srinivas <vidya.srinivas at intel.com>
> > ---
> >  tests/kms_concurrent.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c index
> > 25c67eb469d1..47c441a5a3f7 100644
> > --- a/tests/kms_concurrent.c
> > +++ b/tests/kms_concurrent.c
> > @@ -268,7 +268,8 @@ test_resolution_with_output(data_t *data, enum
> > pipe pipe, int max_planes, igt_ou
> >
> >  		/* switch to lower resolution */
> >  		igt_output_override_mode(output, mode_lo);
> > -		igt_output_set_pipe(output, PIPE_NONE);
> > +		if (is_amdgpu_device(data->drm_fd))
> > +			igt_output_set_pipe(output, PIPE_NONE);
> >  		igt_display_commit2(&data->display, COMMIT_ATOMIC);
> >
> >  		/* switch back to higher resolution */
> > --
> > 2.33.0
> >
> 
> I checked this patch with AMD devices, and it works fine, for this
> reason, feel free to add my:
> 
> Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> Tested-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> 
> Just a note, I think with this change, drivers based on tinyDrm might
> pass this test.

Hello Siqueira, thank you so much for the RB and test confirmation.
@Modem, Bhanuprakash, can you kindly help on this review and merge? Thank you.

Regards
Vidya

> 
> Thanks
> 
> --
> Rodrigo Siqueira
> https://siqueira.tech