[igt-dev] [PATCH i-g-t] tests/kms_flip : skip subtest bo-too-big

[Petri Latvala]

On Tue, Sep 28, 2021 at 10:48:17AM -0400, Mark Yacoub wrote:
> On Tue, Sep 28, 2021 at 10:43 AM Rodrigo Siqueira
> <Rodrigo.Siqueira at amd.com> wrote:
> >
> > Hi,
> >
> > I also tested it using vkms and vc4.
> >
> > I already applied the V1 in the upstream.
> >
> > Thanks
> > Siqueira
> >
> > On 09/28, Aurabindo Pillai wrote:
> > >
> > > On 9/28/21 9:53 AM, Petri Latvala wrote:
> > > > On Tue, Sep 28, 2021 at 09:35:10AM -0400, Aurabindo Pillai wrote:
> > > > > On 9/28/21 5:15 AM, Petri Latvala wrote:
> > > > > > On Mon, Sep 27, 2021 at 07:10:45PM +0000, Pillai, Aurabindo wrote:
> > > > > > > Skipping using the continue statement has the side effect of this
> > > > > > > subtest being absent from the list of subtests, when running the
> > > > > > > test executable with paramter --list-subtest. Is that okay ?
> > > > > > It's not okay btw. When you're not in an igt_fixture or an
> > > > > > igt_subtest, you cannot use anything that touches the hardware or the
> > > > > > running system in any way.
> Hi Petri, can you elaborate more on this. I'm curious to understand
> what you mean. I'm slightly confused.

All subtests must be enumerable regardless of hardware, basically.

In other words, you cannot do

igt_fixture {
  variable_assigned_in_fixture = value;
}

if (variable_assigned_in_fixture)
  igt_subtest("only-exists-sometimes") {}


-- 
Petri Latvala