[igt-dev] [PATCH i-g-t] tests/i915/i915_pm_dc: Changing sysfs open attribute to O_RDONLY

Jigar Bhatt jigar.bhatt at intel.com
Thu Sep 30 12:20:50 UTC 2021


Opening /sys/module/drm_kms_helper/parameters/ in read only mode to
avoid permission issue in dc9-dpms test.

Signed-off-by: Jigar Bhatt <jigar.bhatt at intel.com>
---
 tests/i915/i915_pm_dc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c
index d70ee060..4c9b871c 100644
--- a/tests/i915/i915_pm_dc.c
+++ b/tests/i915/i915_pm_dc.c
@@ -419,7 +419,7 @@ static void setup_dc9_dpms(data_t *data, int dc_target)
 {
 	int prev_dc, sysfs_fd;
 
-	igt_require((sysfs_fd = open(KMS_HELPER, O_RDWR)) >= 0);
+	igt_require((sysfs_fd = open(KMS_HELPER, O_RDONLY)) >= 0);
 	kms_poll_saved_state = igt_sysfs_get_boolean(sysfs_fd, "poll");
 	igt_sysfs_set_boolean(sysfs_fd, "poll", KMS_POLL_DISABLE);
 	close(sysfs_fd);
@@ -449,7 +449,7 @@ static void kms_poll_state_restore(int sig)
 {
 	int sysfs_fd;
 
-	sysfs_fd = open(KMS_HELPER, O_WRONLY);
+	sysfs_fd = open(KMS_HELPER, O_RDONLY);
 	if (sysfs_fd >= 0) {
 		igt_sysfs_set_boolean(sysfs_fd, "poll", kms_poll_saved_state);
 		close(sysfs_fd);
-- 
2.25.1



More information about the igt-dev mailing list