[igt-dev] [PATCH i-g-t 1/2] tests/i915/kms_big_fb: move start of crc calculation past first commit

Juha-Pekka Heikkila juhapekka.heikkila at gmail.com
Thu Apr 7 18:37:32 UTC 2022


First commit may cause modeset on two pipes which can on some machines
take enough time to fill up crc buffer on one pipe causing crc buffer
overflow messages. Moved crc calculation start past first commit
to avoid these messages.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
---
 tests/i915/kms_big_fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/i915/kms_big_fb.c b/tests/i915/kms_big_fb.c
index 8724d6069..b7bcc3401 100644
--- a/tests/i915/kms_big_fb.c
+++ b/tests/i915/kms_big_fb.c
@@ -370,12 +370,12 @@ static bool test_plane(data_t *data)
 		 * rendering pipeline introduces slight differences into
 		 * the result if we try that, and so the crc will not match.
 		 */
-		igt_pipe_crc_start(data->pipe_crc);
 		copy_pattern(data, small_fb, 0, 0, big_fb, x, y,
 			     small_fb->width, small_fb->height);
 
 		igt_display_commit2(&data->display, data->display.is_atomic ?
 				    COMMIT_ATOMIC : COMMIT_UNIVERSAL);
+		igt_pipe_crc_start(data->pipe_crc);
 		igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, &small_crc);
 
 		igt_plane_set_fb(plane, big_fb);
-- 
2.28.0



More information about the igt-dev mailing list