[igt-dev] [PATCH i-g-t] tests/i915/kms_flip_scaled_crc: Fix error message

Petri Latvala petri.latvala at intel.com
Fri Apr 8 06:20:03 UTC 2022


On Thu, Apr 07, 2022 at 10:28:56PM +0300, Juha-Pekka Heikkila wrote:
> There was newline missing from skipping message which caused skips
> to show as incomplete.
> 
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
> ---
>  tests/i915/kms_flip_scaled_crc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/i915/kms_flip_scaled_crc.c b/tests/i915/kms_flip_scaled_crc.c
> index 67ccef31d..9740715f0 100644
> --- a/tests/i915/kms_flip_scaled_crc.c
> +++ b/tests/i915/kms_flip_scaled_crc.c
> @@ -398,7 +398,7 @@ igt_main
>  				if (rval == NOREQUESTEDFORMATONPIPE)
>  					igt_debug("No requested format/modifier on pipe %s\n", kmstest_pipe_name(pipe));
>  			}
> -			igt_require_f(validtests > 0, "No valid pipe/connector/format/mod combination found");
> +			igt_require_f(validtests > 0, "No valid pipe/connector/format/mod combination found\n");

Reviewed-by: Petri Latvala <petri.latvala at intel.com>

Add a closes: line as well if there's a bug report for the incomplete.

>  		}
>  	}
>  	igt_fixture {
> -- 
> 2.28.0
> 


More information about the igt-dev mailing list