[igt-dev] [PATCH v2 08/12] scripts/code_cov_parse_info: better handle test name

Mauro Carvalho Chehab mauro.chehab at linux.intel.com
Tue Apr 12 08:59:07 UTC 2022


From: Mauro Carvalho Chehab <mchehab at kernel.org>

The TN field generated by standard lcov is weird: it keeps
repeating the TN field from time to time. At genhtml, it seems
that only the first one is used.

As we're using TN to indicate the test name, preserve all different
test names at the output file.

Also, printing such names doesn't really makes sense when
--print-used and --print-unused command line options are used,
and printing a list of 100+ names won't make much sense.

So, just remove printing the test names.

Reviewed-by: Ch Sai Gowtham <sai.gowtham.ch at intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab at kernel.org>
---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH v2 00/12] at: https://lore.kernel.org/all/cover.1649753814.git.mchehab@kernel.org/

 scripts/code_cov_parse_info | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/scripts/code_cov_parse_info b/scripts/code_cov_parse_info
index 604812b41580..3e1525a67d99 100755
--- a/scripts/code_cov_parse_info
+++ b/scripts/code_cov_parse_info
@@ -17,8 +17,8 @@ my %used_source;
 my %record;
 my %files;
 my @func_regexes;
+my %test_names;
 my @src_regexes;
-my $testname = "";
 
 my $verbose = 0;
 my $ignore_unused = 0;
@@ -99,11 +99,7 @@ sub parse_info_data($)
 		if (m/^TN:(.*)/) {
 			if ($1 ne $cur_test) {
 				$cur_test = $1;
-				if (!$testname) {
-					$testname = $cur_test;
-				} else {
-					$testname = "Code_coverage_tests";
-				}
+				$test_names{$cur_test} = 1;
 			}
 			$source = $before_sf;
 			$func = $before_sf;
@@ -297,9 +293,13 @@ sub write_filtered_file($)
 {
 	my $filter = shift;
 
+	my $filtered = "";
+
+	foreach my $testname(sort keys %test_names) {
+		$filtered .= "TN:$testname\n";
+	}
+
 	# Generates filtered data
-	my $filtered = "TN:$testname\n";
-
 	foreach my $source(sort keys %record) {
 		next if (!$used_source{$source});
 
@@ -363,10 +363,6 @@ sub print_code_coverage($$$)
 
 	return if (!$print_used && !$print_unused);
 
-	if ($testname ne "") {
-		$testname =~ s/(.*)_on_(\w+)$/$1 on $2/;
-		print "TEST: $testname\n";
-	}
 	my $prev_file = "";
 
 	foreach my $func (sort keys(%all_func)) {
-- 
2.35.1



More information about the igt-dev mailing list