[igt-dev] [PATCH 11/12] code_cov_parse_info: add support for exclude filters

[Mauro Carvalho Chehab]

On Mon, 11 Apr 2022 14:28:24 +0200
Andrzej Hajda <andrzej.hajda at intel.com> wrote:


> > +When used with B<--exclude-source>, exclusions take precedence.
> > +
> > +=item B<--exclude-source> B<[filter's file]>
> > +
> > +Exclude all files that match the regular expressions contained
> > +at the B<[filter's file]>.
> > +
> > +When used with B<--source-filters>, exclusions take precedence.
> > +  
> 
> Now there are two filtering options per functions and two per files.
> Wouldn't be better to squash include/exclude rules into one param in 
> 'rsync like' patterns:
> + include_pattern
> - exclude_pattern
> ...
> This way it would be easier to manage filters - less options, less 
> helper files.

Added support for it. I also preserved the old behavior of placing
just an include pattern without a "+", in order to be backward-compatible.

> One could think about squashing also filters for function and files, but 
> this I am not sure.

I see your point. Yet, I opted to have a single file. Btw,
depending on the file contents, the same filter file can be used as
both source and function filters. For instance, a filter file like:

	+i915
	+gem
	-display
	-selftest

can either be used for functions or sources (or both).

Regards,
Mauro