[igt-dev] [PATCH] intel-ci: Drop kms_setmode at basic-clone-single-crtc from BAT

Petri Latvala petri.latvala at intel.com
Tue Apr 12 14:55:33 UTC 2022


On Tue, Apr 12, 2022 at 08:07:36PM +0530, Modem, Bhanuprakash wrote:
> On Tue-12-04-2022 05:25 pm, Petri Latvala wrote:
> > On Tue, Apr 12, 2022 at 04:16:16PM +0530, Bhanuprakash Modem wrote:
> > > Remove subtest "kms_setmode at basic-clone-single-crtc" from the
> > > BAT test-list as most BAT systems are having single display
> > > only and this subtest requires a multi-display configuration.
> > > 
> > > Cc: Petri Latvala <petri.latvala at intel.com>
> > > Cc: Karthik B S <karthik.b.s at intel.com>
> > > Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
> > 
> > True, there's only fi-snb-2600 that has non-skips on this test. But
> > wouldn't it be better to request more multi-display configs in the BAT
> > farm?
> > 
> >  From what I can see, removing this test from fast-feedback gains under
> > 2 seconds of runtime on said fi-snb-2600, 0.001s on the other
> > platforms. What's the real gain here?
> 
> Yeah, we won't gain much in CI time, but AFAIK, SKIPs are not recommended in
> BAT. Otherwise we need to update the CI-buglog to mark these SKIPs are
> expected.

Marking skips as expected in cibuglog is business as usual, it's not
something to actively try to avoid. We need a bug report for that
anyway, for shards.

I don't know where such a recommendation would come from, it's not a
recommendation from the CI team at least. If it's from validation
people, well, this is CI in question.


-- 
Petri Latvala


More information about the igt-dev mailing list