[igt-dev] [PATCH i-g-t 2/3] test: i915_pm_rpm: conditional initialization of igt_display_t

[Gupta, Anshuman]

> -----Original Message-----
> From: Dixit, Ashutosh <ashutosh.dixit at intel.com>
> Sent: Friday, April 22, 2022 5:00 AM
> To: Gupta, Anshuman <anshuman.gupta at intel.com>
> Cc: igt-dev at lists.freedesktop.org; Nilawar, Badal <badal.nilawar at intel.com>
> Subject: Re: [PATCH i-g-t 2/3] test: i915_pm_rpm: conditional initialization of
> igt_display_t
> 
> On Thu, 21 Apr 2022 10:02:44 -0700, Anshuman Gupta wrote:
> >
> > Initialize igt_display_t display only in case of there are valid drm
> > kms resources.
> >
> > Signed-off-by: Anshuman Gupta <anshuman.gupta at intel.com>
> > ---
> >  tests/i915/i915_pm_rpm.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/i915/i915_pm_rpm.c b/tests/i915/i915_pm_rpm.c index
> > 2cc89eef2..7a0176b2f 100644
> > --- a/tests/i915/i915_pm_rpm.c
> > +++ b/tests/i915/i915_pm_rpm.c
> > @@ -406,9 +406,9 @@ static void init_mode_set_data(struct mode_set_data
> *data)
> >		}
> >
> >		kmstest_set_vt_graphics_mode();
> > +		igt_display_require(&data->display, drm_fd);
> >	}
> >
> > -	igt_display_require(&data->display, drm_fd);
> 
> Is this needed? Isn't display_disabled set to false in setup_environment() for
> headless? Or is this the right thing to do? Maybe somebody from display can
> review? Thanks.
I think we can remove the display_disabled flag.
I will fix this in next revision.
Thanks,
Anshuman Gupta.