[igt-dev] [PATCH v5 2/4] tests/amdgpu/amd_psr: set visual-confirm default to disabled

[David Zhang]

[why & how]
For CI machine, by default it would directly run test case w/o any
manual confirmation. And visual confirm option is to validate the
PSR-SU feature as manual approach, which is for debugging purpose
and not for CI automated scheme.

Pre-set the "visual_confirm" to disable and only to enable the
visual confirm by manual.

changes in v2:
----------------------
- pre-set visual confirm option from enabled to disabled, and set
  it as required argument.

Cc: Rodrigo Siqueira <rodrigo.siqueira at amd.com>
Cc: Harry Wentland <harry.wentland at amd.com>
Cc: Leo Li <sunpeng.li at amd.com>
Cc: Jay Pillai <aurabindo.pillai at amd.com>
Cc: Wayne Lin <wayne.lin at amd.com>

Signed-off-by: David Zhang <dingchen.zhang at amd.com>
Reviewed-by: Aurabindo Pillai <aurabindo.pillai at amd.com>
---
 tests/amdgpu/amd_psr.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/amdgpu/amd_psr.c b/tests/amdgpu/amd_psr.c
index e3a2cb4a..8f47e816 100644
--- a/tests/amdgpu/amd_psr.c
+++ b/tests/amdgpu/amd_psr.c
@@ -66,7 +66,7 @@ typedef struct data {
 struct {
 	bool visual_confirm;
 } opt = {
-	.visual_confirm = true,	/* visual confirm debug option */
+	.visual_confirm = false,	/* visual confirm debug option */
 };
 
 static void draw_color_alpha(igt_fb_t *fb, int x, int y, int w, int h,
@@ -491,7 +491,7 @@ const char *help_str =
 "  --visual-confirm           PSR visual confirm debug option enable\n";
 
 struct option long_options[] = {
-	{"visual-confirm",	optional_argument, NULL, 'v'},
+	{"visual-confirm",	required_argument, NULL, 'v'},
 	{ 0, 0, 0, 0 }
 };
 
-- 
2.25.1