[igt-dev] [PATCH i-g-t v6 3/3] tests/kms_writeback: Enhance kms_writeback for custom modes

[Abhinav Kumar]

Hi Ashutosh

On 8/8/2022 12:49 PM, Dixit, Ashutosh wrote:
> On Mon, 08 Aug 2022 10:41:50 -0700, Abhinav Kumar wrote:
>>
>> Hi Ashutosh
>>
>> On 8/8/2022 10:38 AM, Dixit, Ashutosh wrote:
>>> On Thu, 04 Aug 2022 15:02:35 -0700, Rohith Iyer wrote:
>>>>
>>>> 	igt_subtest("writeback-pixel-formats") {
>>>> +		igt_skip_on(data.dump_check || data.list_modes);
>>>> 		drmModePropertyBlobRes *formats_blob = get_writeback_formats_blob(output);
>>>> 		const char *valid_chars = "01234568 ABCGNRUVXY";
>>>> 		unsigned int i;
>>>
>>> $ ninja -C build
>>> ninja: Entering directory `build'
>>> [120/1183] Compiling C object tests/kms_writeback.p/kms_writeback.c.o
>>> ../tests/kms_writeback.c: In function ‘__igt_unique____real_main480’:
>>> ../tests/kms_writeback.c:532:17: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
>>>     532 |                 drmModePropertyBlobRes *formats_blob = get_writeback_formats_blob(output);
>>>         |                 ^~~~~~~~~~~~~~~~~~~~~~
>>> ../tests/kms_writeback.c:555:17: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
>>>     555 |                 igt_fb_t invalid_output_fb;
>>>         |                 ^~~~~~~~
>>> ../tests/kms_writeback.c:571:17: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
>>>     571 |                 igt_fb_t output_fb;
>>>         |                 ^~~~~~~~
>>> ../tests/kms_writeback.c:586:17: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
>>>     586 |                 igt_fb_t output_fb;
>>>         |                 ^~~~~~~~
>>
>> All these warnings were pre-existing warnings in kms_writeback even before
>> this series and not introduced by this series.
> 
> Hi Abhinav, doesn't seem to be the case, git blame:
> 
>      531 22fa5ae83a885 (Rohith Iyer                   2022-08-04 15:02:35 -0700 531)             igt_skip_on(data.dump_check || data.list

Ah, you are right. Will fix this asap.
> 
>> However, we will be happy to fix these for the benefit of all.
> 
> Thanks, yes please fix.