[igt-dev] [PATCH i-g-t] tests/amdgpu/amd_bypass: skip if connector is not DisplayPort

[Petri Latvala]

On Sat, Aug 13, 2022 at 12:07:50PM -0300, Maíra Canal wrote:
> [why & how]
> It is not possible to access the DSC_CLOCK_EN for non-DP connectors.
> Moreover, the kernel fails when asked to set the CRC source to DPRX on
> non-DP connectors. Therefore, skip the test if the connector is not
> a DisplayPort or eDP connector.
> 
> Signed-off-by: Maíra Canal <mairacanal at riseup.net>
> ---
>  tests/amdgpu/amd_bypass.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/tests/amdgpu/amd_bypass.c b/tests/amdgpu/amd_bypass.c
> index 5ec90884..e5bfcaa2 100644
> --- a/tests/amdgpu/amd_bypass.c
> +++ b/tests/amdgpu/amd_bypass.c
> @@ -316,6 +316,13 @@ static void bypass_8bpc_test(data_t *data)
>  
>  	test_init(data);
>  
> +	/*
> +	 * CRC source cannot be selected without an DP/eDP connector
> +	 */
> +	igt_skip_on_f(data->output->config.connector->connector_type != DRM_MODE_CONNECTOR_DisplayPort ||
> +			data->output->config.connector->connector_type != DRM_MODE_CONNECTOR_eDP,
> +			"no DisplayPort connector found\n");

This condition is always true, you need && instead of ||.


-- 
Petri Latvala



> +
>  	/**
>  	 * 8bpc bypass only makes sense without DSC.
>  	 * DSC is visually lossless but actually still loss exists and any bypass mode
> -- 
> 2.37.1
>