[igt-dev] [PATCH i-g-t v2] tests/amdgpu/amd_bypass: skip if connector is not DisplayPort

Maíra Canal mairacanal at riseup.net
Mon Aug 15 20:33:57 UTC 2022


[why & how]
It is not possible to access the DSC_CLOCK_EN for non-DP connectors.
Moreover, the kernel fails when asked to set the CRC source to DPRX on
non-DP connectors. Therefore, skip the test if the connector is not
a DisplayPort or eDP connector.

Signed-off-by: Maíra Canal <mairacanal at riseup.net>
---
v1 -> v2: https://patchwork.freedesktop.org/patch/497387/
- Change || to && (Petri Latvala).
---
 tests/amdgpu/amd_bypass.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tests/amdgpu/amd_bypass.c b/tests/amdgpu/amd_bypass.c
index 5ec90884..d191779b 100644
--- a/tests/amdgpu/amd_bypass.c
+++ b/tests/amdgpu/amd_bypass.c
@@ -316,6 +316,13 @@ static void bypass_8bpc_test(data_t *data)
 
 	test_init(data);
 
+	/*
+	 * CRC source cannot be select without an DP/eDP connector
+	 */
+	igt_skip_on_f(data->output->config.connector->connector_type != DRM_MODE_CONNECTOR_DisplayPort &&
+			data->output->config.connector->connector_type != DRM_MODE_CONNECTOR_eDP,
+			"no DisplayPort connector found\n");
+
 	/**
 	 * 8bpc bypass only makes sense without DSC.
 	 * DSC is visually lossless but actually still loss exists and any bypass mode
-- 
2.37.2



More information about the igt-dev mailing list