[igt-dev] [PATCH i-g-t 3/3] added newline to 'END TESTLIST' to comply with runner string comparison

[Jake Freeland]

Hi there Petri,

I apologize for my ignorance. This is my first time contributing over
mailing list. Thank you for being understanding. :)

I squashed all three patches into one and sent it under a new thread.
Hopefully that should make things easier for Patchwork.

Jake Freeland

On Wed, Aug 17, 2022 at 10:17 AM Petri Latvala <petri.latvala at intel.com>
wrote:

> On Wed, Aug 17, 2022 at 09:30:22AM -0500, Jake Freeland wrote:
> > It appears that Patchwork is not picking up the second patch in revision
> 2:
> > https://patchwork.freedesktop.org/series/107314/#rev2
> >
> > Is there a way I can manually add the second patch?
>
> You replied to patch 2, making patchwork think it's another version of
> it. To add new patches they should be replies to patch 1. But then
> there's the magic involved where patchwork tries to figure out whether
> it's an additional patch or a new version of patch 1...
>
> It's much simpler to just send the whole series as a whole. And please
> squash patches 2+3 together, from a quick read 3 seems to be just
> fixing patch 2.
>
>
> --
> Petri Latvala
>
>
> >
> > Thank you,
> > Jake Freeland
> >
> > On Wed, Aug 17, 2022 at 9:23 AM Jake Freeland <
> jake at technologyfriends.net>
> > wrote:
> >
> > > ---
> > >  scripts/code_cov_gen_report | 9 +++------
> > >  tests/generate_testlist.sh  | 2 +-
> > >  2 files changed, 4 insertions(+), 7 deletions(-)
> > >
> > > diff --git a/scripts/code_cov_gen_report b/scripts/code_cov_gen_report
> > > index ffc8142e..b0696c51 100755
> > > --- a/scripts/code_cov_gen_report
> > > +++ b/scripts/code_cov_gen_report
> > > @@ -138,8 +138,7 @@ if [ "$MODE" != "info" ]; then
> > >                 echo "Creating per-file info files..."
> > >                 echo -n "" >${MERGED_INFO}.info
> > >                 for i in $RESULTS/*.tar.gz; do
> > > -                       TITLE=$(basename $i)
> > > -                       TITLE=$(basename $TITLE .tar.gz)
> > > +                       TITLE=$(basename "$i" .tar.gz)
> > >
> > >                         echo "Adding results from $i..."
> > >                         tar xf $i
> > > @@ -155,8 +154,7 @@ if [ "$MODE" != "info" ]; then
> > >
> > >                 TITLE=${MERGED_INFO}
> > >         else
> > > -               TITLE=$(basename $RESULTS)
> > > -               TITLE=$(basename $TITLE .tar.gz)
> > > +               TITLE=$(basename "$RESULTS" .tar.gz)
> > >
> > >                 echo "Adding results from $RESULTS..."
> > >                 tar xf $RESULTS
> > > @@ -177,8 +175,7 @@ else
> > >                 echo "Copying $RESULTS to $DEST_DIR..."
> > >                 cp $RESULTS .
> > >
> > > -               TITLE=$(basename $RESULTS)
> > > -               TITLE=$(basename $TITLE .info)
> > > +               TITLE=$(basename "$RESULTS" .info)
> > >         fi
> > >  fi
> > >
> > > diff --git a/tests/generate_testlist.sh b/tests/generate_testlist.sh
> > > index 240a7eb5..ea999a45 100755
> > > --- a/tests/generate_testlist.sh
> > > +++ b/tests/generate_testlist.sh
> > > @@ -15,4 +15,4 @@ while [ $# -gt 0 ] ; do
> > >         shift
> > >  done
> > >
> > > -printf "\nEND TESTLIST" >> $OUTPUT
> > > +printf "\nEND TESTLIST\n" >> $OUTPUT
> > > --
> > > 2.37.2
> > >
> > >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/igt-dev/attachments/20220817/c03fd8b2/attachment.htm>