[igt-dev] [PATCH 2/2] tests/kms_universal_plane: Skip offscreen test for universal API

[Alex Hung]

On 2022-08-25 08:42, Mark Yacoub wrote:
> On Thu, Aug 25, 2022 at 3:01 AM Alex Hung <alex.hung at amd.com> wrote:
>>
>> amdgpu driver intentionally rejects plane outside of the screen and thus
>> this test is skipped on AMD HW.
> Is this an expected DRM behavior? Is this a requirement that user
> spaces are aware of? Maybe it needs a kernel fix if not. bit if it's a
> req, can you link the documentation for reference.

Hi Mark,

The checks were from kernel commits 40d916a2602c and 4abdb72bd8576, and 
the commit explains the rationale as below.

     [why]
     Overlay won't move to a new positon if viewport size is smaller than
     what can be handled. It'd either disappear or stay at the old
     position. This condition is for example hit if overlay is moved too
     much outside of left or top edge of the screen, but it applies to
     any non-cursor plane type.

     [how]
     Reject this contidion at validation time. This gives the calling
     level a chance to handle this gracefully and avoid inconsistent
     behaivor.



> 
>>
>> Signed-off-by: Alex Hung <alex.hung at amd.com>
>> ---
>>   tests/kms_universal_plane.c | 25 ++++++++++++++-----------
>>   1 file changed, 14 insertions(+), 11 deletions(-)
>>
>> diff --git a/tests/kms_universal_plane.c b/tests/kms_universal_plane.c
>> index 9eab1a57..057a14f4 100644
>> --- a/tests/kms_universal_plane.c
>> +++ b/tests/kms_universal_plane.c
>> @@ -242,16 +242,18 @@ functional_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
>>          igt_display_commit2(display, COMMIT_LEGACY);
>>
>>          /* Step 14: Universal API, set primary completely offscreen (CRC 9) */
>> -       igt_assert(drmModeSetPlane(data->drm_fd, primary->drm_plane->plane_id,
>> -                                  output->config.crtc->crtc_id,
>> -                                  test.blue_fb.fb_id, 0,
>> -                                  9000, 9000,
>> -                                  test.mode->hdisplay,
>> -                                  test.mode->vdisplay,
>> -                                  IGT_FIXED(0,0), IGT_FIXED(0,0),
>> -                                  IGT_FIXED(test.mode->hdisplay,0),
>> -                                  IGT_FIXED(test.mode->vdisplay,0)) == 0);
>> -       igt_pipe_crc_collect_crc(test.pipe_crc, &test.crc_9);
>> +       if (!is_amdgpu_device(data->drm_fd)) {
>> +               igt_assert(drmModeSetPlane(data->drm_fd, primary->drm_plane->plane_id,
>> +                                          output->config.crtc->crtc_id,
>> +                                          test.blue_fb.fb_id, 0,
>> +                                          9000, 9000,
>> +                                          test.mode->hdisplay,
>> +                                          test.mode->vdisplay,
>> +                                          IGT_FIXED(0,0), IGT_FIXED(0,0),
>> +                                          IGT_FIXED(test.mode->hdisplay,0),
>> +                                          IGT_FIXED(test.mode->vdisplay,0)) == 0);
>> +               igt_pipe_crc_collect_crc(test.pipe_crc, &test.crc_9);
>> +       }
>>
>>          /*
>>           * Step 15: Explicitly disable primary after it's already been
>> @@ -291,7 +293,8 @@ functional_test_pipe(data_t *data, enum pipe pipe, igt_output_t *output)
>>           * We should be able to move the primary plane completely offscreen
>>           * and have it disable successfully.
>>           */
>> -       igt_assert_crc_equal(&test.crc_5, &test.crc_9);
>> +       if (!is_amdgpu_device(data->drm_fd))
>> +               igt_assert_crc_equal(&test.crc_5, &test.crc_9);
>>
>>          /*
>>           * We should be able to explicitly disable an already
>> --
>> 2.37.2
>>